mirror of
https://github.com/NVIDIA/NemoClaw.git
synced 2026-07-03 03:37:16 +00:00
e33c093c0a
<!-- markdownlint-disable MD041 --> ## Summary <!-- 1-3 sentences: what this PR does and why. --> Define exact-SHA E2E evidence as an explicit precondition of the release process. The candidate commit's `.github/workflows/e2e.yaml` remains the sole source of truth: every declared E2E test needs at least one green execution or an itemized maintainer exception before the exact tag confirmation is requested. ## Changes <!-- Bullet list of key changes. --> - Freeze the candidate SHA with the release plan, then build an evidence ledger across workflow runs, reruns, and attempts. - Require green evidence for every E2E test declared by that SHA's workflow, including explicit-only and expanded matrix executions, without maintaining a second test inventory. - Preserve maintainer discretion through itemized exceptions and invalidate both evidence and exceptions whenever the candidate SHA changes. - Carry the gate through the cut-tag, evening, daily-flow, and maintainer-cadence guidance while keeping overnight QA as additional post-tag validation. - Add a maintainer-policy contract test for the exact-SHA, flaky-run, exception, and confirmation-order invariants. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates <!-- Check all that apply. For any "covered by existing tests", "not applicable", or waiver entry, add a brief justification on the same line or in the Changes section. --> - [x] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [ ] Docs updated for user-facing behavior changes - [x] Docs not applicable — justification: this changes internal maintainer policy and skills only; documentation review found no user-facing CLI, configuration, API, or runtime change. - [x] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [x] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: maintainer-directed release-policy design received an independent diff review; both hardening findings were addressed before commit. - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification <!-- Check each item you ran and confirmed. Leave unchecked items you skipped. Doc-only changes do not require npm test unless you ran it. --> - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [x] Git hooks passed during commit and push, or `npx prek run --from-ref main --to-ref HEAD` passes - [x] Targeted tests pass for changed behavior - [ ] Full `npm test` passes (broad runtime changes only) - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- <!-- DCO sign-off is required in this PR description, and every commit must appear as Verified in GitHub. Run: git config user.name && git config user.email --> Signed-off-by: Carlos Villela <cvillela@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Strengthened release workflow guidance to require pre-tag, exact commit-based E2E evidence before confirming a tag. * Added an evidence-ledger approach using the E2E workflow as the single source of truth, including detailed green evidence (counts plus run/job links and attempt numbers), explicit itemized exceptions for non-green tests, and rules to regenerate evidence if the candidate SHA changes. * **Tests** * Added automated coverage to ensure the updated evidence and confirmation gating rules are enforced across the maintainer release workflows. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Carlos Villela <cvillela@nvidia.com> |
||
|---|---|---|
| .. | ||
| _shared | ||
| nemoclaw-contributor-create-pr | ||
| nemoclaw-contributor-onboard-messaging-channel | ||
| nemoclaw-contributor-update-docs | ||
| nemoclaw-maintainer-cross-issue-sweep | ||
| nemoclaw-maintainer-cut-release-tag | ||
| nemoclaw-maintainer-day | ||
| nemoclaw-maintainer-evening | ||
| nemoclaw-maintainer-find-review-pr | ||
| nemoclaw-maintainer-morning | ||
| nemoclaw-maintainer-normalize-title-tags | ||
| nemoclaw-maintainer-policies | ||
| nemoclaw-maintainer-pr-comparator | ||
| nemoclaw-maintainer-release-notes | ||
| nemoclaw-maintainer-security-code-review | ||
| nemoclaw-maintainer-triage | ||
| nemoclaw-maintainer-verify-stale | ||
| nemoclaw-skills-guide | ||
| nemoclaw-user-guide | ||