kenaug74/Sylius
1
0
Fork 0
mirror of https://github.com/Sylius/Sylius.git synced 2026-07-14 17:10:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

[Theming] Minor improvements to moving ThemeBundle dependency

Browse source
This commit is contained in:
Grzegorz Sadowski 2024-10-04 12:09:08 +02:00
parent f8390b9b11
commit 226116b905
No known key found for this signature in database
GPG key ID: EF87FF4E6E3BD364
4 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
UPGRADE-2.0.md
View file

@ -381,6 +381,7 @@ If your app never changed the hasher name configuration, you don't need to confi
* PayPal Express Checkout gateway has been removed. Use now [PayPal Commerce Platform](https://github.com/Sylius/PayPalPlugin) integration.
## Theming
Dependency on `sylius/theme-bundle` is moved from CoreBundle to ShopBundle and it will no longer be installed if you're running your shop in headless mode.
* Channel's `themeName` form field existence is made optional and depends `ShopBundle` presence.
* The `Sylius\Bundle\CoreBundle\Theme\ChannelBasedThemeContext` has been moved to the `Sylius\Bundle\ShopBundle\Theme\ChannelBasedThemeContext`
* Dependency on `sylius/theme-bundle` is moved from CoreBundle to ShopBundle and it will no longer be installed
if you're running your shop in headless mode.
* Channel's `themeName` form field existence is made optional and depends on `ShopBundle` presence.
* The `Sylius\Bundle\CoreBundle\Theme\ChannelBasedThemeContext` has been moved to the `Sylius\Bundle\ShopBundle\Theme\ChannelBasedThemeContext`.

2
composer.json
View file

@ -83,7 +83,7 @@
"sylius/registry": "^1.6",
"sylius/resource": "^1.12@alpha",
"sylius/resource-bundle": "^1.11 || ^1.12@alpha",
"sylius/theme-bundle": "^2.3",
"sylius/theme-bundle": "^2.4",
"sylius/twig-hooks": "~0.3.0",
"symfony/asset": "^6.4.0 || ^7.1",
"symfony/cache-contracts": "^2.5 || ^3.0",

7
src/Sylius/Bundle/AdminBundle/templates/channel/form/sections/look_and_feel/theme.html.twig
View file

@ -1,6 +1,7 @@
{% set themeName = hookable_metadata.context.form.themeName %}
{% if themeName %}
{% set theme_name = hookable_metadata.context.form.themeName %}
{% if theme_name %}
<div class="col-12 col-md-6">
{{ form_row(hookable_metadata.context.form.themeName, sylius_test_form_attribute('theme')) }}
{{ form_row(theme_name, sylius_test_form_attribute('theme')) }}
</div>
{% endif %}

6
src/Sylius/Bundle/ShopBundle/Resources/config/services/context.xml
View file

@ -11,7 +11,11 @@
-->
<container xmlns="http://symfony.com/schema/dic/services" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
<container
xmlns="http://symfony.com/schema/dic/services"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"
>
<services>
<service id="sylius.theme.context.channel_based" class="Sylius\Bundle\ShopBundle\Theme\ChannelBasedThemeContext">
<argument type="service" id="sylius.context.channel" />