minor #10965 Upgrade to PHPStan 0.12 (pamil)

This PR was merged into the 1.7-dev branch.

Discussion
----------

Related to #10928.

Commits
-------

592e4c152c Upgrade to PHPStan 0.12

composer.json

@@ -121,9 +121,9 @@
         "pamil/phpspec-skip-example-extension": "^4.0",
         "pamil/prophecy-common": "^0.1",
         "phpspec/phpspec": "^5.0",
-        "phpstan/phpstan-doctrine": "0.11.6",
-        "phpstan/phpstan": "0.11.19",
-        "phpstan/phpstan-webmozart-assert": "0.11.3",
+        "phpstan/phpstan-doctrine": "0.12.3",
+        "phpstan/phpstan": "0.12.3",
+        "phpstan/phpstan-webmozart-assert": "0.12.0",
         "phpunit/phpunit": "^7.0",
         "psr/event-dispatcher": "^1.0",
         "sensiolabs/security-checker": "^5.0",

phpstan.neon

@@ -41,3 +41,5 @@ parameters:
         - '/Symfony\\Component\\ExpressionLanguage\\ParserCache\\ParserCacheInterface/'
         - '/Symfony\\Component\\ExpressionLanguage\\ParserCache\\ParserCacheAdapter/'
         - '/Class Symfony\\Component\\Config\\Definition\\Builder\\TreeBuilder does not have a constructor and must be instantiated without any parameters/'
+
+        - '/Access to an undefined property Doctrine\\Common\\Collections\\ArrayCollection/'

src/Sylius/Behat/Page/Shop/Product/ShowPage.php

@@ -165,15 +165,6 @@ class ShowPage extends SymfonyPage implements ShowPageInterface
         return null !== $this->getElement('reviews')->find('css', sprintf('.comment:contains("%s")', $title));
     }
 
-    public function waitForValidationErrors(int $timeout): bool
-    {
-        $errorsContainer = $this->getElement('selecting_variants');
-
-        $this->getDocument()->waitFor($timeout, function () use ($errorsContainer) {
-            return false !== $errorsContainer->has('css', '[class ~="sylius-validation-error"]');
-        });
-    }
-
     public function isOutOfStock(): bool
     {
         return $this->hasElement('out_of_stock');

src/Sylius/Behat/Page/Shop/Product/ShowPageInterface.php

@@ -64,8 +64,6 @@ interface ShowPageInterface extends PageInterface
 
     public function hasReviewTitled(string $title): bool;
 
-    public function waitForValidationErrors(int $timeout): bool;
-
     public function isOutOfStock(): bool;
 
     public function isMainImageDisplayed(): bool;

src/Sylius/Bundle/CoreBundle/Command/ShowAvailablePluginsCommand.php

@@ -25,6 +25,7 @@ final class ShowAvailablePluginsCommand extends Command
     /**
      * @var iterable<PluginInfo>
      *
+     * @phpstan-var ArrayCollection<PluginInfo>
      * @psalm-var ArrayCollection<array-key, PluginInfo>
      */
     private $plugins;