kenaug74/Sylius
1
0
Fork 0
mirror of https://github.com/Sylius/Sylius.git synced 2026-07-14 17:10:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

refactor #14071 [Addressing] Minor refactor (coldic3)

Browse source 
This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.11          |
| Bug fix?        | no                                                       |
| New feature?    | no                                           |
| BC breaks?      | no                                                     |
| Deprecations?   | no |
| Related tickets |  refactoring of https://github.com/Sylius/Sylius/pull/14061, https://github.com/Sylius/Sylius/pull/14067                     |
| License         | MIT                                                          |

Commits
-------

6953125f4e [Addressing] Minor refactor
This commit is contained in:
Grzegorz Sadowski 2022-06-10 10:58:47 +02:00 • committed by GitHub
commit 476d229574
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/Sylius/Behat/Context/Transform/ZoneMemberContext.php
View file

@ -56,9 +56,9 @@ final class ZoneMemberContext implements Context
/** /**
* @Transform /^"([^"]+)", "([^"]+)" and "([^"]+)" country members$/ * @Transform /^"([^"]+)", "([^"]+)" and "([^"]+)" country members$/
*/ */
public function getCountryTypeZoneMembersByNames(string ...$name): array public function getCountryTypeZoneMembersByNames(string ...$names): array
{ {
$codes = $name; $codes = $names;
array_walk($codes, fn (&$item) => $item = $this->countryNameConverter->convertToCode($item)); array_walk($codes, fn (&$item) => $item = $this->countryNameConverter->convertToCode($item));
return $this->getZoneMembersByCodes($codes); return $this->getZoneMembersByCodes($codes);

6
src/Sylius/Bundle/ApiBundle/Serializer/ZoneDenormalizer.php
View file

@ -25,14 +25,12 @@ use Symfony\Component\Serializer\Normalizer\DenormalizerAwareInterface;
use Symfony\Component\Serializer\Normalizer\DenormalizerAwareTrait; use Symfony\Component\Serializer\Normalizer\DenormalizerAwareTrait;
use Webmozart\Assert\Assert; use Webmozart\Assert\Assert;
/** /** @experimental */
* @experimental
*/
final class ZoneDenormalizer implements ContextAwareDenormalizerInterface, DenormalizerAwareInterface final class ZoneDenormalizer implements ContextAwareDenormalizerInterface, DenormalizerAwareInterface
{ {
use DenormalizerAwareTrait; use DenormalizerAwareTrait;
private const ALREADY_CALLED = 'sylius_command_denormalizer_already_called'; private const ALREADY_CALLED = 'sylius_zone_denormalizer_already_called';
public function __construct(private IriConverterInterface $iriConverter) public function __construct(private IriConverterInterface $iriConverter)
{ {

7
src/Sylius/Bundle/ApiBundle/spec/Serializer/ZoneDenormalizerSpec.php
View file

@ -86,8 +86,7 @@ class ZoneDenormalizerSpec extends ObjectBehavior
ZoneMemberInterface $germanyZone, ZoneMemberInterface $germanyZone,
ZoneMemberInterface $franceZone, ZoneMemberInterface $franceZone,
DenormalizerInterface $denormalizer, DenormalizerInterface $denormalizer,
): void ): void {
{
$belgiumZone->getCode()->willReturn('EU-BE'); $belgiumZone->getCode()->willReturn('EU-BE');
$germanyZone->getCode()->willReturn('EU-DE'); $germanyZone->getCode()->willReturn('EU-DE');
$franceZone->getCode()->willReturn('EU-FR'); $franceZone->getCode()->willReturn('EU-FR');
@ -114,7 +113,7 @@ class ZoneDenormalizerSpec extends ObjectBehavior
null, null,
[ [
AbstractNormalizer::OBJECT_TO_POPULATE => $zone, AbstractNormalizer::OBJECT_TO_POPULATE => $zone,
'sylius_command_denormalizer_already_called' => true, 'sylius_zone_denormalizer_already_called' => true,
] ]
)->shouldBeCalled(); )->shouldBeCalled();
@ -163,7 +162,7 @@ class ZoneDenormalizerSpec extends ObjectBehavior
null, null,
[ [
AbstractNormalizer::OBJECT_TO_POPULATE => $zone, AbstractNormalizer::OBJECT_TO_POPULATE => $zone,
'sylius_command_denormalizer_already_called' => true, 'sylius_zone_denormalizer_already_called' => true,
] ]
)->shouldBeCalled(); )->shouldBeCalled();