Changes after CR

This commit is contained in:
Michał Pysiak 2024-10-29 12:26:10 +01:00
parent f7a75e2cdb
commit 48dcd94f0e
No known key found for this signature in database
GPG key ID: 9C1F2D0F99830187
5 changed files with 11 additions and 12 deletions

View file

@ -31,16 +31,12 @@
The previous namespaces are still usable, but are considered deprecated and may be removed in future versions of `Resource` packages, update them at your own convenience. The previous namespaces are still usable, but are considered deprecated and may be removed in future versions of `Resource` packages, update them at your own convenience.
2. Package `enshrined/svg-sanitize` has been removed from the project due to license incompatibility with Sylius. You can still use it in your project by adding it manually. Just add it to your `composer.json` file: 2. Package `enshrined/svg-sanitize` has been removed from the project due to license incompatibility with Sylius. You can still use it in your project by adding it manually:
```json ```bash
{ composer require enshrined/svg-sanitize
"require": {
"enshrined/svg-sanitize": "^0.16",
}
}
``` ```
Also `svg` image support has been removed. If you want to use `svg` images in your project, add `image/svg+xml` to the list of allowed mime types in `CoreBundle` configuration. Also, uploading `svg` image support has been removed. If you want to use `svg` images in your project, add `image/svg+xml` to the list of allowed mime types in the `CoreBundle` configuration.
```yaml ```yaml
sylius_core: sylius_core:

View file

@ -227,9 +227,7 @@ final class ManagingProductImagesContext implements Context
{ {
Assert::contains( Assert::contains(
$this->responseChecker->getError($this->client->getLastResponse()), $this->responseChecker->getError($this->client->getLastResponse()),
sprintf( 'The file is not a valid image.',
'The file is not a valid image.',
),
); );
} }

View file

@ -27,6 +27,8 @@ trigger_deprecation(
); );
/** /**
* @internal * @internal
*
* @deprecated
*/ */
final class LiipImageFiltersPass implements CompilerPassInterface final class LiipImageFiltersPass implements CompilerPassInterface
{ {

View file

@ -136,7 +136,7 @@
<service id="sylius.validator.max_integer" alias="Sylius\Bundle\CoreBundle\Validator\Constraints\MaxIntegerValidator" /> <service id="sylius.validator.max_integer" alias="Sylius\Bundle\CoreBundle\Validator\Constraints\MaxIntegerValidator" />
<service id="sylius.validator.allowed_mime_types" class="Sylius\Bundle\CoreBundle\Validator\Constraints\AllowedImageMimeTypesValidator"> <service id="sylius.validator.allowed_image_mime_types" class="Sylius\Bundle\CoreBundle\Validator\Constraints\AllowedImageMimeTypesValidator">
<argument>%sylius_core.allowed_images_mime_types%</argument> <argument>%sylius_core.allowed_images_mime_types%</argument>
<tag name="validator.constraint_validator" alias="sylius_image_allowed_mime_types_validator" /> <tag name="validator.constraint_validator" alias="sylius_image_allowed_mime_types_validator" />
</service> </service>

View file

@ -24,6 +24,9 @@ trigger_deprecation(
FilterExtension::class, FilterExtension::class,
); );
/**
* @deprecated
*/
final class FilterExtension extends BaseFilterExtension final class FilterExtension extends BaseFilterExtension
{ {
public function __construct(private string $imagesPath, CacheManager $cache) public function __construct(private string $imagesPath, CacheManager $cache)