From 4d4fecd2482226fddfe364509572e28976147c48 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Fr=C3=A9mont?= Date: Wed, 6 May 2026 07:49:07 +0200 Subject: [PATCH] Apply suggestions from coderabbit --- .../Bundle/AdminBundle/Menu/CompositeMenuBuilder.php | 2 +- .../Main/OfficialSupportMenuProvider.php} | 4 ++-- .../Menu/Provider/MenuProviderInterface.php | 11 +++++++++++ .../AdminBundle/Resources/config/services/menu.php | 4 ++-- 4 files changed, 16 insertions(+), 5 deletions(-) rename src/Sylius/Bundle/AdminBundle/Menu/{OfficialSupportProvider.php => Provider/Main/OfficialSupportMenuProvider.php} (94%) diff --git a/src/Sylius/Bundle/AdminBundle/Menu/CompositeMenuBuilder.php b/src/Sylius/Bundle/AdminBundle/Menu/CompositeMenuBuilder.php index 3b1c72c9ec..0c7cac4fb0 100644 --- a/src/Sylius/Bundle/AdminBundle/Menu/CompositeMenuBuilder.php +++ b/src/Sylius/Bundle/AdminBundle/Menu/CompositeMenuBuilder.php @@ -18,7 +18,7 @@ use Knp\Menu\ItemInterface; use Sylius\Bundle\AdminBundle\Menu\Provider\MenuProviderInterface; use Webmozart\Assert\Assert; -final class CompositeMenuBuilder implements MenuBuilderInterface +final readonly class CompositeMenuBuilder implements MenuBuilderInterface { /** * @param iterable $providers diff --git a/src/Sylius/Bundle/AdminBundle/Menu/OfficialSupportProvider.php b/src/Sylius/Bundle/AdminBundle/Menu/Provider/Main/OfficialSupportMenuProvider.php similarity index 94% rename from src/Sylius/Bundle/AdminBundle/Menu/OfficialSupportProvider.php rename to src/Sylius/Bundle/AdminBundle/Menu/Provider/Main/OfficialSupportMenuProvider.php index 8bf073234b..e74f4a5cb2 100644 --- a/src/Sylius/Bundle/AdminBundle/Menu/OfficialSupportProvider.php +++ b/src/Sylius/Bundle/AdminBundle/Menu/Provider/Main/OfficialSupportMenuProvider.php @@ -11,12 +11,12 @@ declare(strict_types=1); -namespace Sylius\Bundle\AdminBundle\Menu; +namespace Sylius\Bundle\AdminBundle\Menu\Provider\Main; use Knp\Menu\ItemInterface; use Sylius\Bundle\AdminBundle\Menu\Provider\MenuProviderInterface; -final readonly class OfficialSupportProvider implements MenuProviderInterface +final readonly class OfficialSupportMenuProvider implements MenuProviderInterface { public function __invoke(ItemInterface $menu): void { diff --git a/src/Sylius/Bundle/AdminBundle/Menu/Provider/MenuProviderInterface.php b/src/Sylius/Bundle/AdminBundle/Menu/Provider/MenuProviderInterface.php index 594cc111bf..23321a3376 100644 --- a/src/Sylius/Bundle/AdminBundle/Menu/Provider/MenuProviderInterface.php +++ b/src/Sylius/Bundle/AdminBundle/Menu/Provider/MenuProviderInterface.php @@ -1,5 +1,16 @@ set('sylius_admin.menu_builder.provider.main.official_support', OfficialSupportProvider::class) + ->set('sylius_admin.menu_builder.provider.main.official_support', OfficialSupportMenuProvider::class) ->tag('sylius_admin.main_menu_provider', ['priority' => -600]) ;