kenaug74/Sylius
1
0
Fork 0
mirror of https://github.com/Sylius/Sylius.git synced 2026-07-14 17:10:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

[ADR][API] Update ADR for providing locales after changing the approach

Browse source
This commit is contained in:
Grzegorz Sadowski 2022-03-15 12:12:12 +01:00
parent 46ad6e19ef
commit 4e82e09fdf
No known key found for this signature in database
GPG key ID: EF87FF4E6E3BD364
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
adr/2021_07_05_api_providing_locales_available_in_active_channel.md
View file

@ -1,7 +1,8 @@
# Using data provider for getting available locales in active channel for shop user # Using Doctrine Collection extension for getting available locales in active channel for shop user
* Status: proposed * Status: accepted
* Date: 2021-07-05 * Propose date: 2021-07-05
* Update date: 2022-03-15
## Context and Problem Statement ## Context and Problem Statement
Customer should have access only to locales available in their channel Customer should have access only to locales available in their channel
@ -16,11 +17,11 @@ Customer should have access only to locales available in their channel
### Using Data Provider ### Using Data Provider
* Good, because we already have this approach for older resources
* Good, because it is easy to implement * Good, because it is easy to implement
* Bad, because using data providers omits extra Doctrine extensions like pagination * Bad, because using data providers omits extra Doctrine extensions like pagination
## Decision Outcome ## Decision Outcome
Chosen option: Using Data Provider Chosen option: **"Using Doctrine Collection extension"**
Shops shouldn't have many locales for each channel, so lack of a pagination is smaller problem than creating overcomplicated query in Doctrine Collection extension
This option is consistent with current approach and does not omit Doctrine extensions like pagination.