kenaug74/Sylius
1
0
Fork 0
mirror of https://github.com/Sylius/Sylius.git synced 2026-07-14 17:10:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

minor #17471 Fix channel collector's name to match the tag's id (GSadee)

Browse source 
This PR was merged into the 1.14 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.14
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes https://github.com/Sylius/Sylius/issues/17468
| License         | MIT

According to [the Symfony docs](https://symfony.com/doc/current/profiler.html#enabling-custom-data-collectors), the value returned by the getName() method must match the id defined in the `data_collector` tag.
<!--
 - Bug fixes must be submitted against the 1.13 branch
 - Features and deprecations must be submitted against the 1.14 branch
 - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------
  Fix channel collector's name to match the tag's id
This commit is contained in:
Kamil Grygierzec 2024-11-15 13:55:11 +01:00 • committed by GitHub
commit 5c22699406
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Sylius/Bundle/ChannelBundle/Collector/ChannelCollector.php
View file

@ -70,7 +70,7 @@ final class ChannelCollector extends DataCollector
public function getName(): string
{
return 'sylius.collector.channel';
return 'sylius.channel_collector';
}
private function pluckChannel(ChannelInterface $channel): array