kenaug74/Sylius
1
0
Fork 0
mirror of https://github.com/Sylius/Sylius.git synced 2026-07-17 02:18:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

refactor #12846 [API] Unification of filtration namespaces (lchrusciel)

Browse source 
This PR was merged into the 1.11-dev branch.
labels: bc-break

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | yes
| Deprecations?   | no
| Related tickets | 
| License         | MIT

All class folders are kept in the singular form. What is more, we already have one filter in the `Sylius\Bundle\ApiBundle\Doctrine\Filter` namespace

<!--
 - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

7fcc65cf25 [API] Unification of filtration namespaces
This commit is contained in:
Grzegorz Sadowski 2021-07-27 14:13:22 +02:00 • committed by GitHub
commit 5dd517bb21
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
UPGRADE-API-1.11.md
View file

@ -1,5 +1,7 @@
# UPGRADE FROM `v1.10.X` TO `v1.11.0`
1. `Sylius\Bundle\ApiBundle\Doctrine\Filters\ExchangeRateFilter` and `Sylius\Bundle\ApiBundle\Doctrine\Filters\TranslationOrderNameAndLocaleFilter` has been moved to `Sylius\Bundle\ApiBundle\Doctrine\Filter\ExchangeRateFilter` and `Sylius\Bundle\ApiBundle\Doctrine\Filter\TranslationOrderNameAndLocaleFilter` respectively.
1. `Sylius\Bundle\ApiBundle\View\CartShippingMethodInterface` and `Sylius\Bundle\ApiBundle\View\CartShippingMethod` have been removed.
1. `Sylius\Bundle\ApiBundle\View\Factory\CartShippingMethodFactoryInterface` and `Sylius\Bundle\ApiBundle\View\Factory\CartShippingMethodFactory` have been removed.

2
src/Sylius/Bundle/ApiBundle/Doctrine/Filters/ExchangeRateFilter.php → src/Sylius/Bundle/ApiBundle/Doctrine/Filter/ExchangeRateFilter.php
View file

@ -11,7 +11,7 @@
declare(strict_types=1);
namespace Sylius\Bundle\ApiBundle\Doctrine\Filters;
namespace Sylius\Bundle\ApiBundle\Doctrine\Filter;
use ApiPlatform\Core\Bridge\Doctrine\Orm\Filter\AbstractContextAwareFilter;
use ApiPlatform\Core\Bridge\Doctrine\Orm\Util\QueryNameGeneratorInterface;

2
src/Sylius/Bundle/ApiBundle/Doctrine/Filters/TranslationOrderNameAndLocaleFilter.php → src/Sylius/Bundle/ApiBundle/Doctrine/Filter/TranslationOrderNameAndLocaleFilter.php
View file

@ -11,7 +11,7 @@
declare(strict_types=1);
namespace Sylius\Bundle\ApiBundle\Doctrine\Filters;
namespace Sylius\Bundle\ApiBundle\Doctrine\Filter;
use ApiPlatform\Core\Bridge\Doctrine\Common\Filter\OrderFilterInterface;
use ApiPlatform\Core\Bridge\Doctrine\Orm\Filter\AbstractContextAwareFilter;

4
src/Sylius/Bundle/ApiBundle/Resources/config/services/filters.xml
View file

@ -97,12 +97,12 @@
<tag name="api_platform.filter" />
</service>
<service id="sylius.api.exchange_rate_filter" class="Sylius\Bundle\ApiBundle\Doctrine\Filters\ExchangeRateFilter">
<service id="sylius.api.exchange_rate_filter" class="Sylius\Bundle\ApiBundle\Doctrine\Filter\ExchangeRateFilter">
<argument type="service" id="doctrine" />
<tag name="api_platform.filter" />
</service>
<service id="sylius.api.translation_order_name_and_locale_filter" class="Sylius\Bundle\ApiBundle\Doctrine\Filters\TranslationOrderNameAndLocaleFilter">
<service id="sylius.api.translation_order_name_and_locale_filter" class="Sylius\Bundle\ApiBundle\Doctrine\Filter\TranslationOrderNameAndLocaleFilter">
<argument type="service" id="doctrine" />
<tag name="api_platform.filter" />
</service>