kenaug74/Sylius
1
0
Fork 0
mirror of https://github.com/Sylius/Sylius.git synced 2026-07-14 17:10:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

[Promotion] Changes in promotions system to fit scenarios

Browse source
This commit is contained in:
Mateusz Zalewski 2016-02-22 15:54:01 +01:00
parent 8711b8c695
commit 5fef96c8e0
2 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/Sylius/Component/Promotion/Checker/CartQuantityRuleChecker.php
View file

@ -28,11 +28,7 @@ class CartQuantityRuleChecker implements RuleCheckerInterface
return false;
}
if (isset($configuration['equal']) && $configuration['equal']) {
return $subject->getPromotionSubjectCount() >= $configuration['count'];
}
return $subject->getPromotionSubjectCount() > $configuration['count'];
return $subject->getPromotionSubjectCount() >= $configuration['count'];
}
/**

11
src/Sylius/Component/Promotion/spec/Checker/CartQuantityRuleCheckerSpec.php
View file

@ -34,7 +34,7 @@ class CartQuantityRuleCheckerSpec extends ObjectBehavior
{
$subject->getPromotionSubjectCount()->shouldBeCalled()->willReturn(0);
$this->isEligible($subject, ['count' => 10, 'equal' => false])->shouldReturn(false);
$this->isEligible($subject, ['count' => 10])->shouldReturn(false);
}
function it_should_recognize_subject_as_not_eligible_if_cart_quantity_is_less_then_configured(
@ -42,7 +42,7 @@ class CartQuantityRuleCheckerSpec extends ObjectBehavior
) {
$subject->getPromotionSubjectCount()->shouldBeCalled()->willReturn(7);
$this->isEligible($subject, ['count' => 10, 'equal' => false])->shouldReturn(false);
$this->isEligible($subject, ['count' => 10])->shouldReturn(false);
}
function it_should_recognize_subject_as_eligible_if_cart_quantity_is_greater_then_configured(
@ -50,16 +50,15 @@ class CartQuantityRuleCheckerSpec extends ObjectBehavior
) {
$subject->getPromotionSubjectCount()->shouldBeCalled()->willReturn(12);
$this->isEligible($subject, ['count' => 10, 'equal' => false])->shouldReturn(true);
$this->isEligible($subject, ['count' => 10])->shouldReturn(true);
}
function it_should_recognize_subject_as_eligible_if_cart_quantity_is_equal_with_configured_depending_on_equal_setting(
function it_should_recognize_subject_as_eligible_if_cart_quantity_is_equal_with_configured(
PromotionCountableSubjectInterface $subject
) {
$subject->getPromotionSubjectCount()->shouldBeCalled()->willReturn(10);
$this->isEligible($subject, ['count' => 10, 'equal' => false])->shouldReturn(false);
$this->isEligible($subject, ['count' => 10, 'equal' => true])->shouldReturn(true);
$this->isEligible($subject, ['count' => 10])->shouldReturn(true);
}
function it_should_return_cart_quantity_configuration_form_type()