kenaug74/Sylius
1
0
Fork 0
mirror of https://github.com/Sylius/Sylius.git synced 2026-07-14 17:10:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Merge branch '1.8'

Browse source 
* 1.8:
  [ADR] Minor text adjustments
  Fixed deprecated option usage on Email validator
This commit is contained in:
Łukasz Chruściel 2020-09-08 13:52:34 +02:00
commit 9a85fc7176
No known key found for this signature in database
GPG key ID: 428B9D810DB2ACDF
6 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
adr/2020_09_01_admin_and_shop_split.md
View file

@ -14,7 +14,7 @@ and simplify the relations between resources. However, this change rose a lot of
* Different serialization for different users is not trivial. Some relations between objects are also contextual, so
admin can see many more links than the regular visitor or shop user.
* Endpoints like "Product Show" are resolved differently depending on the context as well. The shop products are determined
based on the slug(taking into account the current channel), while the administrator is browsing products by code. This
based on the slug (taking into account the current channel), while the administrator is browsing products by code. This
separation blurs the product identifier, and it is not clear which route should be considered as IRI.
* the split was not complete. Two separate log in endpoints have to be preserved, due to our user architecture and the
decision that we want to be explicit, which user is trying to log in.
@ -42,12 +42,12 @@ Every option will be described considering products example fetched by shop user
`{"id": 1, "slug": 2, "prices": {}, "admin_related_information" : "" }`
* Good, because there is only one endpoint for the products.
* Bad, because depending on the currently logged in user, the IRIs between related products (or on product list) has be
* Bad, because depending on the currently logged in user, the IRIs between related products (or on the product list) have been
changed (between slug and code).
* Bad, because it is not clear how to operate on endpoint before jumping into documentation. (For example tax rates
endpoint is not exposed for shop users).
* Bad, because we have to declare authorization rules on endpoint basis, while some of them will have really complicated
rules (different strategies for admin, shop user and guest)
rules (different strategies for admin, shop user and guest).
### Adding additional suffix for path

2
src/Sylius/Bundle/ApiBundle/Resources/config/validation/RegisterShopUser.xml
View file

@ -62,7 +62,7 @@
</constraint>
<constraint name="Email">
<option name="message">sylius.customer.email.invalid</option>
<option name="strict">true</option>
<option name="mode">strict</option>
<option name="groups">
<value>sylius</value>
</option>

2
src/Sylius/Bundle/CoreBundle/Resources/config/validation/AdminUser.xml
View file

@ -30,7 +30,7 @@
</constraint>
<constraint name="Email">
<option name="message">sylius.user.email.invalid</option>
<option name="strict">true</option>
<option name="mode">strict</option>
<option name="groups">sylius</option>
</constraint>
</property>

2
src/Sylius/Bundle/CoreBundle/Resources/config/validation/Channel.xml
View file

@ -48,7 +48,7 @@
</constraint>
<constraint name="Email">
<option name="message">sylius.channel.contact_email.invalid</option>
<option name="strict">true</option>
<option name="mode">strict</option>
<option name="groups">
<value>sylius</value>
</option>

2
src/Sylius/Bundle/CustomerBundle/Resources/config/validation/Customer.xml
View file

@ -71,7 +71,7 @@
</constraint>
<constraint name="Email">
<option name="message">sylius.customer.email.invalid</option>
<option name="strict">true</option>
<option name="mode">strict</option>
<option name="groups">
<value>sylius</value>
<value>sylius_customer_guest</value>

2
src/Sylius/Bundle/UserBundle/Resources/config/validation/PasswordResetRequest.xml
View file

@ -27,7 +27,7 @@
</constraint>
<constraint name="Email">
<option name="message">sylius.user.email.invalid</option>
<option name="strict">true</option>
<option name="mode">strict</option>
<option name="groups">sylius</option>
</constraint>
</property>