From 7327c744399ac0c9eeaefcde962495aaa496a12a Mon Sep 17 00:00:00 2001 From: Sylius Bot Date: Mon, 25 Dec 2023 02:16:00 +0000 Subject: [PATCH 1/2] [CS][DX] Refactor --- .../LocaleBundle/Context/RequestHeaderBasedLocaleContext.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Sylius/Bundle/LocaleBundle/Context/RequestHeaderBasedLocaleContext.php b/src/Sylius/Bundle/LocaleBundle/Context/RequestHeaderBasedLocaleContext.php index 3b4a7d8803..ad6f9d2bb4 100644 --- a/src/Sylius/Bundle/LocaleBundle/Context/RequestHeaderBasedLocaleContext.php +++ b/src/Sylius/Bundle/LocaleBundle/Context/RequestHeaderBasedLocaleContext.php @@ -27,7 +27,7 @@ final class RequestHeaderBasedLocaleContext implements LocaleContextInterface { private const NO_CODE_VALID_STUB = 'NO_CODE_VALID_STUB'; - /** @var array $availableLocalesCodes */ + /** @var array */ private array $availableLocalesCodes = []; public function __construct(private RequestStack $requestStack, private LocaleProviderInterface $localeProvider) @@ -44,7 +44,7 @@ final class RequestHeaderBasedLocaleContext implements LocaleContextInterface if ([] === $this->availableLocalesCodes) { $this->availableLocalesCodes = array_unique(array_merge( [$this->localeProvider->getDefaultLocaleCode()], - $this->localeProvider->getAvailableLocalesCodes() + $this->localeProvider->getAvailableLocalesCodes(), )); } From 24bd5786a57273ace40e771ca87a5c0ee2a72b2d Mon Sep 17 00:00:00 2001 From: Jacob Tobiasz Date: Sun, 24 Dec 2023 08:59:27 +0100 Subject: [PATCH 2/2] Define permissions for all workflows Co-authored-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com> --- .github/workflows/auto-merge.yaml | 5 +++++ .github/workflows/ci__full.yaml | 3 +++ .github/workflows/ci__minimal.yaml | 3 +++ .github/workflows/ci__unstable.yaml | 3 +++ .github/workflows/ci_e2e-custom.yaml | 3 +++ .github/workflows/ci_e2e-mariadb.yaml | 3 +++ .github/workflows/ci_e2e-mysql.yaml | 3 +++ .github/workflows/ci_e2e-pgsql.yaml | 3 +++ .github/workflows/ci_e2e-unstable.yaml | 3 +++ .github/workflows/ci_packages-unstable.yaml | 3 +++ .github/workflows/ci_packages.yaml | 3 +++ .github/workflows/ci_static-checks.yaml | 3 +++ .github/workflows/documentation.yaml | 3 +++ .github/workflows/refactor.yaml | 4 ++++ .github/workflows/social-media-notifications.yaml | 3 +++ .github/workflows/upmerge_pr.yaml | 4 ++++ 16 files changed, 52 insertions(+) diff --git a/.github/workflows/auto-merge.yaml b/.github/workflows/auto-merge.yaml index d98fa6c652..44d25b144d 100644 --- a/.github/workflows/auto-merge.yaml +++ b/.github/workflows/auto-merge.yaml @@ -3,8 +3,13 @@ name: Auto-merge on: pull_request: ~ +permissions: + contents: read + jobs: auto-merge: + permissions: + pull-requests: write runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 diff --git a/.github/workflows/ci__full.yaml b/.github/workflows/ci__full.yaml index d51f01d6bc..fd4c58cbf0 100644 --- a/.github/workflows/ci__full.yaml +++ b/.github/workflows/ci__full.yaml @@ -10,6 +10,9 @@ concurrency: group: ci-${{ github.workflow }}-${{ github.ref }}-full cancel-in-progress: true +permissions: + contents: read + jobs: static-checks: strategy: diff --git a/.github/workflows/ci__minimal.yaml b/.github/workflows/ci__minimal.yaml index d35ec6def2..03d4b0579f 100644 --- a/.github/workflows/ci__minimal.yaml +++ b/.github/workflows/ci__minimal.yaml @@ -16,6 +16,9 @@ concurrency: group: ci-${{ github.workflow }}-${{ github.ref }}-minimal cancel-in-progress: true +permissions: + contents: read + jobs: static-checks: name: Static checks diff --git a/.github/workflows/ci__unstable.yaml b/.github/workflows/ci__unstable.yaml index 1135955341..b3173a7f96 100644 --- a/.github/workflows/ci__unstable.yaml +++ b/.github/workflows/ci__unstable.yaml @@ -19,6 +19,9 @@ concurrency: group: ci-${{ github.workflow }}-${{ github.ref }}-unstable cancel-in-progress: true +permissions: + contents: read + jobs: e2e-unstable: name: End-to-end tests (Unstable) diff --git a/.github/workflows/ci_e2e-custom.yaml b/.github/workflows/ci_e2e-custom.yaml index b5227fc178..3384dfc7a3 100644 --- a/.github/workflows/ci_e2e-custom.yaml +++ b/.github/workflows/ci_e2e-custom.yaml @@ -10,6 +10,9 @@ on: type: string default: "" +permissions: + contents: read + jobs: behat-no-js-unstable-symfony: runs-on: ubuntu-latest diff --git a/.github/workflows/ci_e2e-mariadb.yaml b/.github/workflows/ci_e2e-mariadb.yaml index d9459703af..5aea23e66c 100644 --- a/.github/workflows/ci_e2e-mariadb.yaml +++ b/.github/workflows/ci_e2e-mariadb.yaml @@ -14,6 +14,9 @@ on: required: true type: string +permissions: + contents: read + jobs: get-matrix: runs-on: ubuntu-latest diff --git a/.github/workflows/ci_e2e-mysql.yaml b/.github/workflows/ci_e2e-mysql.yaml index 55a0364eef..55e1dffd57 100644 --- a/.github/workflows/ci_e2e-mysql.yaml +++ b/.github/workflows/ci_e2e-mysql.yaml @@ -14,6 +14,9 @@ on: required: true type: string +permissions: + contents: read + jobs: get-matrix: runs-on: ubuntu-latest diff --git a/.github/workflows/ci_e2e-pgsql.yaml b/.github/workflows/ci_e2e-pgsql.yaml index de15371c7d..53165863d9 100644 --- a/.github/workflows/ci_e2e-pgsql.yaml +++ b/.github/workflows/ci_e2e-pgsql.yaml @@ -14,6 +14,9 @@ on: required: true type: string +permissions: + contents: read + jobs: get-matrix: runs-on: ubuntu-latest diff --git a/.github/workflows/ci_e2e-unstable.yaml b/.github/workflows/ci_e2e-unstable.yaml index 0bdfc4ecc6..43f7f1bc88 100644 --- a/.github/workflows/ci_e2e-unstable.yaml +++ b/.github/workflows/ci_e2e-unstable.yaml @@ -10,6 +10,9 @@ on: default: false workflow_dispatch: ~ +permissions: + contents: read + jobs: behat-no-js-unstable: runs-on: ubuntu-latest diff --git a/.github/workflows/ci_packages-unstable.yaml b/.github/workflows/ci_packages-unstable.yaml index 7b84c19346..95fa480f44 100644 --- a/.github/workflows/ci_packages-unstable.yaml +++ b/.github/workflows/ci_packages-unstable.yaml @@ -14,6 +14,9 @@ on: type: boolean default: false +permissions: + contents: read + jobs: get-matrix: runs-on: ubuntu-latest diff --git a/.github/workflows/ci_packages.yaml b/.github/workflows/ci_packages.yaml index ac1005cf58..b33583d715 100644 --- a/.github/workflows/ci_packages.yaml +++ b/.github/workflows/ci_packages.yaml @@ -14,6 +14,9 @@ on: required: true type: string +permissions: + contents: read + jobs: get-matrix: runs-on: ubuntu-latest diff --git a/.github/workflows/ci_static-checks.yaml b/.github/workflows/ci_static-checks.yaml index b03c337f9a..b1cae6f302 100644 --- a/.github/workflows/ci_static-checks.yaml +++ b/.github/workflows/ci_static-checks.yaml @@ -14,6 +14,9 @@ on: required: true type: string +permissions: + contents: read + jobs: get-matrix: runs-on: ubuntu-latest diff --git a/.github/workflows/documentation.yaml b/.github/workflows/documentation.yaml index beaa5a1cd6..57a113a8c2 100644 --- a/.github/workflows/documentation.yaml +++ b/.github/workflows/documentation.yaml @@ -16,6 +16,9 @@ on: cron: "0 1 * * 6" # Run at 1am every Saturday workflow_dispatch: ~ +permissions: + contents: read + jobs: test: runs-on: ubuntu-latest diff --git a/.github/workflows/refactor.yaml b/.github/workflows/refactor.yaml index d01cd62e8d..da5de27e82 100644 --- a/.github/workflows/refactor.yaml +++ b/.github/workflows/refactor.yaml @@ -6,6 +6,10 @@ on: cron: "0 2 * * *" # Run every day at 2am workflow_dispatch: ~ +permissions: + contents: write + pull-requests: write + jobs: coding-standard: runs-on: ubuntu-latest diff --git a/.github/workflows/social-media-notifications.yaml b/.github/workflows/social-media-notifications.yaml index 0e6f27e157..7492ec0aa5 100644 --- a/.github/workflows/social-media-notifications.yaml +++ b/.github/workflows/social-media-notifications.yaml @@ -4,6 +4,9 @@ on: release: types: [created] +permissions: + contents: read + jobs: build: runs-on: ubuntu-latest diff --git a/.github/workflows/upmerge_pr.yaml b/.github/workflows/upmerge_pr.yaml index be4c6fc697..ee16b8ef28 100644 --- a/.github/workflows/upmerge_pr.yaml +++ b/.github/workflows/upmerge_pr.yaml @@ -5,6 +5,10 @@ on: - cron: "0 2 * * *" workflow_dispatch: ~ + +permissions: + contents: write + pull-requests: write jobs: upmerge: