kenaug74/Sylius
1
0
Fork 0
mirror of https://github.com/Sylius/Sylius.git synced 2026-07-14 09:02:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

[2.2] Fix SyliusUiBundle compiler passes priority (#19057)
Some checks are pending
Continuous Integration (Minimal) / Static checks (push) Waiting to run
Details
Continuous Integration (Minimal) / Tests (MariaDB) (push) Blocked by required conditions
Details
Continuous Integration (Minimal) / Tests (MySQL) (push) Blocked by required conditions
Details
Continuous Integration (Minimal) / Javascript Tests (MySQL) (push) Blocked by required conditions
Details
Continuous Integration (Minimal) / Tests (PostgreSQL) (push) Blocked by required conditions
Details
Continuous Integration (Minimal) / Frontend (push) Blocked by required conditions
Details
Continuous Integration (Minimal) / Packages (push) Blocked by required conditions
Details

Browse source 
| Q               | A
|-----------------|-----
| Branch?         |2.2
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes #18978
| License         | MIT

https://github.com/Sylius/Sylius/pull/18979
This commit is contained in:
Kamil Grygierzec 2026-06-18 13:52:19 +02:00 • committed by GitHub
commit c070c1a1ae
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
UPGRADE-2.2.md
View file

@ -53,6 +53,14 @@ SYLIUS_TELEMETRY_SALT=your-custom-salt
1. The `Sylius\Bundle\ReviewBundle\Updater\ReviewableRatingUpdaterInterface::updateFromReview()` method has been deprecated and will be removed in Sylius 3.0. Use state machine mechanism implemented by Symfony Workflow instead. 1. The `Sylius\Bundle\ReviewBundle\Updater\ReviewableRatingUpdaterInterface::updateFromReview()` method has been deprecated and will be removed in Sylius 3.0. Use state machine mechanism implemented by Symfony Workflow instead.
## Bahavior changes
1. The `LiveComponentTagPass` and `TwigComponentTagPass` in `SyliusUiBundle` were registered with a priority of `500`,
which caused them to run before Symfony's autoconfiguration passes (priority `100`).
As a result, services tagged via `#[AutoconfigureTag]` or `registerForAutoconfiguration()` with the `sylius.twig_component`
or `sylius.live_component.*` tag did not receive the `twig.component` tag.
The priority has been lowered to `50` to ensure Symfony's autoconfiguration runs first.
## Admin UI ## Admin UI
1. A new `modal-portal.js` script has been added to `AdminBundle`. 1. A new `modal-portal.js` script has been added to `AdminBundle`.

4
src/Sylius/Bundle/UiBundle/SyliusUiBundle.php
View file

@ -25,7 +25,7 @@ final class SyliusUiBundle extends Bundle
{ {
public function build(ContainerBuilder $container): void public function build(ContainerBuilder $container): void
{ {
$container->addCompilerPass(new LiveComponentTagPass(), priority: 500); $container->addCompilerPass(new LiveComponentTagPass(), priority: 50);
$container->addCompilerPass(new TwigComponentTagPass(), priority: 500); $container->addCompilerPass(new TwigComponentTagPass(), priority: 50);
} }
} }