kenaug74/Sylius
1
0
Fork 0
mirror of https://github.com/Sylius/Sylius.git synced 2026-07-14 09:02:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Coding standards fixes

Browse source
This commit is contained in:
SirDomin 2021-06-16 19:13:39 +02:00
parent 384f99d188
commit d93a6fb177
3 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
adr/2021_06_15_api_platform_config_customization.md
View file

@ -5,7 +5,7 @@
## Context and Problem Statement
Its difficult to overwrite or remove endpoints.
It's difficult to overwrite or remove endpoints.
## Considered Options
@ -36,7 +36,7 @@ in specified directory all we need to do is create config we want to overwrite,
This is example config to remove specific operation, more examples can be found in docs.
* Good, because its easy to understand, you can overwrite any endpoint in just a few lines from any place specified in api platform config.
* Good, because it's easy to understand, you can overwrite any endpoint in just a few lines from any place specified in api platform config.
* Bad, because we need to overwrite and modify services provided by API Platform, differences between API Platform versions can break our application.
## Decision Outcome

3
src/Sylius/Bundle/ApiBundle/ApiPlatform/Factory/MergingExtractorResourceMetadataFactory.php
View file

@ -17,7 +17,6 @@ use ApiPlatform\Core\Exception\ResourceClassNotFoundException;
use ApiPlatform\Core\Metadata\Extractor\ExtractorInterface;
use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
use ApiPlatform\Core\Metadata\Resource\ResourceMetadata;
use Sylius\Bundle\ApiBundle\ApiPlatform\ConfigMergeManager;
use Sylius\Bundle\ApiBundle\ApiPlatform\ResourceMetadataPropertyValueResolver;
/**
@ -29,7 +28,7 @@ final class MergingExtractorResourceMetadataFactory implements ResourceMetadataF
/** @var ExtractorInterface */
private $extractor;
/** @var ResourceMetadataFactoryInterface */
/** @var ResourceMetadataFactoryInterface */
private $decorated;
/** @var ResourceMetadataPropertyValueResolver */

3
src/Sylius/Bundle/ApiBundle/Resources/config/services.xml
View file

@ -151,8 +151,7 @@
<argument type="service" id="api_platform.identifier.converter" on-invalid="ignore" />
</service>
<service id="Sylius\Bundle\ApiBundle\ApiPlatform\ConfigMergeManager" >
</service>
<service id="Sylius\Bundle\ApiBundle\ApiPlatform\ConfigMergeManager" />
<service id="Sylius\Bundle\ApiBundle\ApiPlatform\ResourceMetadataPropertyValueResolver" >
<argument type="service" id="Sylius\Bundle\ApiBundle\ApiPlatform\ConfigMergeManager" />