kenaug74/Sylius
1
0
Fork 0
mirror of https://github.com/Sylius/Sylius.git synced 2026-07-14 09:02:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Update typehint for $publicDir (#17051)

Browse source 
| Q               | A
|-----------------|-----
| Branch?         | 2.0 
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | none
| License         | MIT

$publicDir is a value of `%sylius_core.public_dir%` which is a string
value (usually a `sylius_core.public_dir:
'%kernel.project_dir%/public'`), not a bool value. Which now causes
assets to be installed into a wrong directory.

Pre-fix:
```bash
➜ bin/console sylius:install:assets --no-interaction;
Installing Sylius assets for environment dev.
Created "/Users/username/Code/Sylius-Standard/1/assets" directory.
Created "/Users/username/Code/Sylius-Standard/1/bundles" directory.
```

Post-fix:
```bash
➜ bin/console sylius:install:assets --no-interaction;
Installing Sylius assets for environment dev.
Created "/Users/username/Code/Sylius-Standard/public/assets" directory.
Created "/Users/username/Code/Sylius-Standard/public/bundles" directory.
```
This commit is contained in:
Grzegorz Sadowski 2024-09-30 06:53:39 +02:00 • committed by GitHub
commit eda9403073
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Sylius/Bundle/CoreBundle/Console/Command/InstallAssetsCommand.php
View file

@ -29,7 +29,7 @@ final class InstallAssetsCommand extends AbstractInstallCommand
public function __construct(
protected readonly EntityManagerInterface $entityManager,
protected readonly CommandDirectoryChecker $commandDirectoryChecker,
protected readonly bool $publicDir,
protected readonly string $publicDir,
) {
parent::__construct($this->entityManager, $this->commandDirectoryChecker);
}