Use DateTimeImmutable in model constructors for DBAL 4.x compatibility

(cherry picked from commit bbb6d00e2f)

src/Sylius/Component/Addressing/Model/Address.php

@@ -54,7 +54,7 @@ class Address implements AddressInterface
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function getId()

src/Sylius/Component/Attribute/Model/Attribute.php

@@ -51,7 +51,7 @@ class Attribute implements AttributeInterface, \Stringable
     {
         $this->initializeTranslationsCollection();
 
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Attribute/tests/Model/AttributeTest.php

@@ -104,7 +104,7 @@ class AttributeTest extends TestCase
 
     public function testCreationDateShouldBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
         $this->attribute->setCreatedAt($date);
         self::assertSame($date, $this->attribute->getCreatedAt());
     }
@@ -116,7 +116,7 @@ class AttributeTest extends TestCase
 
     public function testLastUpdateDateShouldBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
         $this->attribute->setUpdatedAt($date);
         self::assertSame($date, $this->attribute->getUpdatedAt());
     }

src/Sylius/Component/Attribute/tests/Model/AttributeValueTest.php

@@ -90,8 +90,8 @@ class AttributeValueTest extends TestCase
             'text' => 'Lorem ipsum',
             'integer' => 42,
             'float' => 6.66,
-            'datetime' => new \DateTime(),
-            'date' => new \DateTime(),
+            'datetime' => new \DateTimeImmutable(),
+            'date' => new \DateTimeImmutable(),
             'json' => ['foo' => 'bar'],
         ];
 

src/Sylius/Component/Channel/Model/Channel.php

@@ -40,7 +40,7 @@ class Channel implements ChannelInterface, \Stringable
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Channel/tests/Model/ChannelTest.php

@@ -88,7 +88,7 @@ class ChannelTest extends TestCase
 
     public function testCreationDateShouldBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
         $this->channel->setCreatedAt($date);
         self::assertSame($date, $this->channel->getCreatedAt());
     }
@@ -100,7 +100,7 @@ class ChannelTest extends TestCase
 
     public function testLastUpdateDateShouldBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
         $this->channel->setUpdatedAt($date);
         self::assertSame($date, $this->channel->getUpdatedAt());
     }

src/Sylius/Component/Core/Model/OrderItemUnit.php

@@ -31,7 +31,7 @@ class OrderItemUnit extends BaseOrderItemUnit implements OrderItemUnitInterface
     {
         parent::__construct($orderItem);
 
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function getShipment(): ?BaseShipmentInterface

src/Sylius/Component/Core/Model/Taxon.php

@@ -31,7 +31,7 @@ class Taxon extends BaseTaxon implements TaxonInterface, Comparable
     {
         parent::__construct();
 
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
         $this->images = new ArrayCollection();
     }
 

src/Sylius/Component/Core/tests/Model/ChannelPricingLogEntryTest.php

@@ -30,7 +30,7 @@ final class ChannelPricingLogEntryTest extends TestCase
         $this->channelPricing = $this->createMock(ChannelPricingInterface::class);
         $this->channelPricingLogEntry = new ChannelPricingLogEntry(
             $this->channelPricing,
-            new \DateTime(),
+            new \DateTimeImmutable(),
             1000,
             2000,
         );
@@ -45,7 +45,7 @@ final class ChannelPricingLogEntryTest extends TestCase
     {
         $this->channelPricingLogEntry = new ChannelPricingLogEntry(
             $this->channelPricing,
-            new \DateTime(),
+            new \DateTimeImmutable(),
             1000,
             null,
         );

src/Sylius/Component/Core/tests/Model/OrderItemUnitTest.php

@@ -45,7 +45,7 @@ final class OrderItemUnitTest extends TestCase
         $this->productVariant = $this->createMock(ProductVariantInterface::class);
         $this->nonNeutralTaxAdjustment = $this->createMock(AdjustmentInterface::class);
         $this->neutralTaxAdjustment = $this->createMock(AdjustmentInterface::class);
-        $this->date = new \DateTime();
+        $this->date = new \DateTimeImmutable();
         $this->orderItemUnit = new OrderItemUnit($this->orderItem);
     }
 

src/Sylius/Component/Currency/Model/Currency.php

@@ -28,7 +28,7 @@ class Currency implements CurrencyInterface, \Stringable
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Currency/Model/ExchangeRate.php

@@ -33,7 +33,7 @@ class ExchangeRate implements ExchangeRateInterface
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function getId()

src/Sylius/Component/Currency/tests/Model/CurrencyTest.php

@@ -67,7 +67,7 @@ final class CurrencyTest extends TestCase
 
     public function testCreationDateShouldBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
         $this->currency->setCreatedAt($date);
         self::assertSame($date, $this->currency->getCreatedAt());
     }
@@ -79,7 +79,7 @@ final class CurrencyTest extends TestCase
 
     public function testLastUpdateDateShouldBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
         $this->currency->setUpdatedAt($date);
         self::assertSame($date, $this->currency->getUpdatedAt());
     }

src/Sylius/Component/Currency/tests/Model/ExchangeRateTest.php

@@ -71,7 +71,7 @@ final class ExchangeRateTest extends TestCase
 
     public function testCreationDateShouldBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->exchangeRate->setCreatedAt($date);
         self::assertSame($date, $this->exchangeRate->getCreatedAt());
@@ -84,7 +84,7 @@ final class ExchangeRateTest extends TestCase
 
     public function testLastUpdateDateShouldBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->exchangeRate->setUpdatedAt($date);
         self::assertSame($date, $this->exchangeRate->getUpdatedAt());

src/Sylius/Component/Customer/Model/Customer.php

@@ -51,7 +51,7 @@ class Customer implements CustomerInterface, \Stringable
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Locale/Model/Locale.php

@@ -28,7 +28,7 @@ class Locale implements LocaleInterface, \Stringable
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Order/Model/Adjustment.php

@@ -54,13 +54,13 @@ class Adjustment implements AdjustmentInterface
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __clone()
     {
         $this->id = null;
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
         $this->updatedAt = null;
     }
 

src/Sylius/Component/Order/Model/Order.php

@@ -60,7 +60,7 @@ class Order implements OrderInterface
         $this->items = new ArrayCollection();
         $this->adjustments = new ArrayCollection();
 
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function getId()
@@ -85,7 +85,7 @@ class Order implements OrderInterface
 
     public function completeCheckout(): void
     {
-        $this->checkoutCompletedAt = new \DateTime();
+        $this->checkoutCompletedAt = new \DateTimeImmutable();
     }
 
     public function getNumber(): ?string

src/Sylius/Component/Order/tests/Model/AdjustmentTest.php

@@ -295,7 +295,7 @@ final class AdjustmentTest extends TestCase
 
     public function testResetsInternalInformationWhileCloning(): void
     {
-        $this->adjustment->setUpdatedAt(new \DateTime());
+        $this->adjustment->setUpdatedAt(new \DateTimeImmutable());
         $new = clone $this->adjustment;
 
         $this->assertNotSame($new->getCreatedAt(), $this->adjustment->getCreatedAt());

src/Sylius/Component/Payment/Model/Payment.php

@@ -44,7 +44,7 @@ class Payment implements PaymentInterface
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
         $this->paymentRequests = new ArrayCollection();
     }
 

src/Sylius/Component/Payment/Model/PaymentMethod.php

@@ -44,7 +44,7 @@ class PaymentMethod implements PaymentMethodInterface, \Stringable
     {
         $this->initializeTranslationsCollection();
 
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Payment/Model/PaymentRequest.php

@@ -36,7 +36,7 @@ class PaymentRequest implements PaymentRequestInterface
         protected PaymentInterface $payment,
         protected PaymentMethodInterface $method,
     ) {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function getId(): ?string

src/Sylius/Component/Product/Model/Product.php

@@ -52,7 +52,7 @@ class Product implements ProductInterface, \Stringable
     {
         $this->initializeTranslationsCollection();
 
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
         $this->attributes = new ArrayCollection();
         $this->associations = new ArrayCollection();
         $this->variants = new ArrayCollection();

src/Sylius/Component/Product/Model/ProductAssociation.php

@@ -35,8 +35,8 @@ class ProductAssociation implements ProductAssociationInterface
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
-        $this->updatedAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
+        $this->updatedAt = new \DateTimeImmutable();
         $this->associatedProducts = new ArrayCollection();
     }
 

src/Sylius/Component/Product/Model/ProductAssociationType.php

@@ -38,8 +38,8 @@ class ProductAssociationType implements ProductAssociationTypeInterface, \String
     {
         $this->initializeTranslationsCollection();
 
-        $this->createdAt = new \DateTime();
-        $this->updatedAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
+        $this->updatedAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Product/Model/ProductOption.php

@@ -44,7 +44,7 @@ class ProductOption implements ProductOptionInterface, \Stringable
         $this->initializeTranslationsCollection();
         $this->values = new ArrayCollection();
 
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Product/Model/ProductVariant.php

@@ -48,7 +48,7 @@ class ProductVariant implements ProductVariantInterface
         $this->initializeTranslationsCollection();
         $this->optionValues = new ArrayCollection();
 
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function getId()

src/Sylius/Component/Promotion/Model/Promotion.php

@@ -83,7 +83,7 @@ class Promotion implements PromotionInterface
     {
         $this->initializeTranslationsCollection();
 
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
         $this->coupons = new ArrayCollection();
         $this->rules = new ArrayCollection();
         $this->actions = new ArrayCollection();

src/Sylius/Component/Promotion/Model/PromotionCoupon.php

@@ -107,7 +107,7 @@ class PromotionCoupon implements PromotionCouponInterface
             return false;
         }
 
-        if (null !== $this->expiresAt && $this->expiresAt < new \DateTime()) {
+        if (null !== $this->expiresAt && $this->expiresAt < new \DateTimeImmutable()) {
             return false;
         }
 

src/Sylius/Component/Promotion/tests/Model/PromotionTest.php

@@ -139,7 +139,7 @@ final class PromotionTest extends TestCase
 
     public function testShouldStartsAtDateBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->promotion->setStartsAt($date);
 
@@ -148,7 +148,7 @@ final class PromotionTest extends TestCase
 
     public function testShouldEndsAtDateBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->promotion->setEndsAt($date);
 

src/Sylius/Component/Review/Model/Review.php

@@ -42,7 +42,7 @@ class Review implements ReviewInterface
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function getId()

src/Sylius/Component/Shipping/Model/Shipment.php

@@ -42,7 +42,7 @@ class Shipment implements ShipmentInterface, \Stringable
     public function __construct()
     {
         $this->units = new ArrayCollection();
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Shipping/Model/ShipmentUnit.php

@@ -30,7 +30,7 @@ class ShipmentUnit implements ShipmentUnitInterface, \Stringable
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Shipping/Model/ShippingCategory.php

@@ -33,7 +33,7 @@ class ShippingCategory implements ShippingCategoryInterface, \Stringable
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Shipping/Model/ShippingMethod.php

@@ -63,7 +63,7 @@ class ShippingMethod implements ShippingMethodInterface, \Stringable
     {
         $this->initializeTranslationsCollection();
 
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
         $this->rules = new ArrayCollection();
     }
 

src/Sylius/Component/Shipping/tests/Model/ShipmentTest.php

@@ -137,7 +137,7 @@ final class ShipmentTest extends TestCase
 
     public function testShouldCreationDateBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->shipment->setCreatedAt($date);
 
@@ -151,7 +151,7 @@ final class ShipmentTest extends TestCase
 
     public function testShouldLastUpdateDateBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->shipment->setUpdatedAt($date);
 

src/Sylius/Component/Shipping/tests/Model/ShipmentUnitTest.php

@@ -85,7 +85,7 @@ final class ShipmentUnitTest extends TestCase
 
     public function testShouldCreationDateBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->shipmentUnit->setCreatedAt($date);
 
@@ -99,7 +99,7 @@ final class ShipmentUnitTest extends TestCase
 
     public function testShouldLastUpdateDateBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->shipmentUnit->setUpdatedAt($date);
 

src/Sylius/Component/Shipping/tests/Model/ShippingCategoryTest.php

@@ -74,7 +74,7 @@ final class ShippingCategoryTest extends TestCase
 
     public function testShouldCreationDateBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->shippingCategory->setCreatedAt($date);
 
@@ -88,7 +88,7 @@ final class ShippingCategoryTest extends TestCase
 
     public function testShouldLastUpdateDateBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->shippingCategory->setUpdatedAt($date);
 

src/Sylius/Component/Shipping/tests/Model/ShippingMethodTest.php

@@ -171,7 +171,7 @@ final class ShippingMethodTest extends TestCase
 
     public function testShouldCreationDateBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->shippingMethod->setCreatedAt($date);
 
@@ -185,7 +185,7 @@ final class ShippingMethodTest extends TestCase
 
     public function testShouldLastUpdateDateBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->shippingMethod->setUpdatedAt($date);
 
@@ -199,7 +199,7 @@ final class ShippingMethodTest extends TestCase
 
     public function testShouldArchivingDateBeMutable(): void
     {
-        $date = new \DateTime();
+        $date = new \DateTimeImmutable();
 
         $this->shippingMethod->setArchivedAt($date);
 

src/Sylius/Component/Taxation/Model/TaxCategory.php

@@ -39,7 +39,7 @@ class TaxCategory implements TaxCategoryInterface, \Stringable
     public function __construct()
     {
         $this->rates = new ArrayCollection();
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function __toString(): string

src/Sylius/Component/Taxation/Model/TaxRate.php

@@ -46,7 +46,7 @@ class TaxRate implements TaxRateInterface
 
     public function __construct()
     {
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
     }
 
     public function getId()

src/Sylius/Component/User/Model/User.php

@@ -92,7 +92,7 @@ class User implements UserInterface, \Stringable
     {
         $this->oauthAccounts = new ArrayCollection();
 
-        $this->createdAt = new \DateTime();
+        $this->createdAt = new \DateTimeImmutable();
 
         // Set here to overwrite default value from trait
         $this->enabled = false;
@@ -238,7 +238,7 @@ class User implements UserInterface, \Stringable
             return false;
         }
 
-        $threshold = new \DateTime();
+        $threshold = new \DateTimeImmutable();
         $threshold->sub($ttl);
 
         return $threshold <= $this->passwordRequestedAt;