This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#13749, replaces #13889 |
| License | MIT |
Commits
-------
[Admin][Taxon] Fix slug generation to work based on the parent field
[Behat][Admin][Taxon] Autogenerate slug based on selected parent
[Admin][Taxon] Fallback from parent code to id when generating a slug
This PR was merged into the 1.12 branch.
Discussion
----------
…ctOptionAutocompleteType
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes#13742 |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Before:
After:
Commits
-------
[Admin][ProductOptions] Changed form ProductOptionChoiceType to ProductOptionAutocompleteType
Revert BC breaking changes
minor improvements
Show option name as a choice name instead of code
Fix Main Taxon autocomplete scenarios
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
Commits
-------
[Country] Add violation for adding provinces with duplicated codes
[Behat][Admin][Country] Tests for saving duplicated provinces
Update phpstan baseline
[Country] Additional validation for duplicated provinces names
[Behat][Admin][Country] Validation of saving duplicated province names
* 1.12:
Fix BC Break in SelectAttributeChoicesCollectionType
[Admin] Add note to channel form about disabling account verification
[Documentation] Add note about accessing guest orders by shop user
Update docs/book/orders/checkout.rst
Update checkout.rst
Update upgrade file
[Behat] Add scenario for checking if attribute is correctly added with values
Use localeCode in ProductAttribute form to prevent logic from breaking when not using default locale
Remove usage of defaultLocaleCode from SelectAttributeChoicesCollectionType
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes [#X](https://github.com/Sylius/Sylius/issues/12112) |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
ec4d4d890f Remove usage of defaultLocaleCode from SelectAttributeChoicesCollectionType
fd1834479d Use localeCode in ProductAttribute form to prevent logic from breaking when not using default locale
a959f7c4fc [Behat] Add scenario for checking if attribute is correctly added with values
f297799825 Update upgrade file
a9546e0081 Fix BC Break in SelectAttributeChoicesCollectionType
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes [#X](https://github.com/Sylius/Sylius/issues/15193) |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
it is now possible to configure decimal amounts with comma without validation errors
Commits
-------
e85e30b553 Fix configuring amount for catalog promotions fixed discount actions
* 1.12:
Fix cart promotion percentage discount to be rounded to 2 decimal places
Fix catalog promotion percentage discount to be rounded to 2 decimal places
Declare symfony/service-contracts dependency where needed
Remove leftovers after removing ResettingCartContextInterface
Rename the pass and preventing tagging with the kernel.reset tag twice
Remove custom ResettingCartContextInterface
Abstracts out ShopBasedCartContext::reset to an interface
* 1.12:
Add behat scenarios
Add subquery to findMyNamePart method
[Behat][Admin] Cover validation errors while adding a new avatar
Fix rendering admin creation form with errors
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | replaces #13241
| License | MIT
Previously, when an avatar was added while creating a new administrator, once any error occurred, Sylius was throwing `500` due to being unable to create a CSRF token for the delete button.
Commits
-------
b8576ddbda Fix rendering admin creation form with errors
1394309b87 [Behat][Admin] Cover validation errors while adding a new avatar
* 1.12:
Provide post-CR fixes
Fix static analysis
Adjust scenarios to use less technical language
Prevent placing an order with not available shipping method
Add behat scenario covering preventing a placing an order with a disabled shipping method
Add behat scenario covering expires session while cart updating
[API] Fix CommandDenormalizer ignoring custom property names
Update OrderController.php with early return
check before refreshing from db
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | yes
| New feature? | kinda
| BC breaks? | no
| Deprecations? | no
| Related tickets | replaces #12870
| License | MIT |
Currently, when we disable a shipping method, and someone is after the shipping method choice step and has the disabled shipping method selected, they'll be able to place the order. After merging this PR, the customer is going to see
> The "%shippingMethodName%" shipping method is not available, please choose another one.
message.
Commits
-------
f95513cc39 Add behat scenario covering preventing a placing an order with a disabled shipping method
f4603f9eb7 Prevent placing an order with not available shipping method
d70afa1951 Fix static analysis
a267e2ea3e Provide post-CR fixes
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#15151 |
| License | MIT |
Commits
-------
check before refreshing from db
Update OrderController.php with early return
Add behat scenario covering expires session while cart updating
Adjust scenarios to use less technical language
