* 1.12:
Do not hardcode checking cart state in processors
Determine Order being processable on itself
Add conflict for doctrine/orm:2.14.2
[CS][DX] Refactor
[Tasks] Improve Robo task
[Product][Association] Fix attaching association with numeric code
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
Hello everyone 👋
While browsing our order processors, I figure out that they lack some extendability regarding whether they should be run or not. Most of them have hardcoded check if the `$state` is `cart` - which is a good default behavior, but does not have to be right for everyone (imagine we have a `draft` order, that we still want to process, but is not placed yet). If we want to change that, we would have to override the whole processor just to adjust/remove a simple if at the beginning.
I think such information (whether the order is processable or not) can be a part of the `Order` entity itself. It's easy to override and we avoid some additional services. We could even go further and have other methods like this for specific cases, but let's start simple.
I believe the general rule of thumb regarding the DX and extendability should be "never use any primitive value directly in the condition in any service" (constant is also a value, as it's not easily replaceable 💃).
Cheers 🚀🖖
Commits
-------
c19bb1d15b Determine Order being processable on itself
15a38eafb7 Do not hardcode checking cart state in processors
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
Commits
-------
6b95ae7a8e [Behat][API] Checking out as guest with a registered email
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 |
| Bug fix? | somewhat |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
The new length was working fine with migrations and caused no issues when using `schema:update` after migrations, but for whatever reason, using only `schema:update` is throwing hissy-fits:
Commits
-------
f59304da05 [Maintenance] Fix schema update with longer UserOAuth tokens
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 <!-- see the comment below --> |
| Bug fix? | yes https://github.com/Sylius/Sylius/pull/14837/files#diff-da930a9fffeeb2b173c4be59006198c99fd7d758dd4a5d422a2ff9f74a0a1d1bL69-R69 |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
5264b484c1 [ProductVariant] Fix serialization group of POST operation
8feb851ece [ProductVariant][API] Add possibility to POST variant translations
9bd6d0650d [ProductVariant][API] Add possibility to PUT variant translations
4875256995 [ProductVariant][API] Add channelCode validation in channelPricings list
ad2c534af0 [ProductVariant][API] Add product validation
af4a421c33 [Exception] Map UnexpectedValueException to 400 HTTP status code
7eed74b20d [API] Rename the resource from ProductVariantTranslation to ProductVariantTranslations
3a519e8692 [API] Remove non-iri id field from ProductVariantTranslation and ChannelPricing serialization
d40ecdffc0 [Behat] Update context to pass validation
3dccd16479 [Behat][API] Introduce common ResponseContext service
7483de555f [Behat][API] Use ResponseContext within suites
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Related tickets | fixes#13586 |
| License | MIT |
Commits
-------
5e77372844 [Maintenance] Add missing Spec for HasEnabledEntityValidator
f2920e71eb [Maintenance] Slight refactor of HasEnabledEntityValidator
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| License | MIT
Commits
-------
de58169f58 Add conflict for doctrine/orm:2.14.2
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 <!-- see the comment below --> |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
398f04699b [PriceHistory] Add Compiler Pass for upgrade between Sylius 1.12 and Sylius 1.13 version
This PR was merged into the 1.12 branch.
Discussion
----------
This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yaml).
Commits
-------
5fed4db64e [CS][DX] Refactor
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 and 1.13 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
It runs `composer validate` after `composer update` and handles the case of already created directories
Commits
-------
b9d2233b07 [Tasks] Improve Robo task
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 <!-- see the comment below --> |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes #X, partially #Y, mentioned in #Z |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
239281ebc2 [UpgradeFile] Introduce upgrade from Sylius 1.12 with PriceHistoryPlugin to Sylius 1.13
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes#12339
| License | MIT
<!--
- Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible)
- Features and deprecations must be submitted against the master branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
0f62196135 [Product][Association] Fix attaching association with numeric code
* 1.12:
Change application's version to v1.12.8-dev
Generate changelog for v1.12.7
Change application's version to v1.12.7
[API] Add order item removal validation and return proper HTTP status code
Update sylius-chart.js
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
Commits
-------
35adb93d20 [Maintenance] Rename OnFlushEntityObserverListener service
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | none |
| License | MIT |
- Bug fixes to load chart.js
Seen information on the documentation of chart.js: https://www.chartjs.org/docs/latest/getting-started/integration.html#quick-start
Commits
-------
150a1496d0 Update sylius-chart.js
This PR was merged into the 1.13 branch.
Discussion
----------
This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yaml).
Commits
-------
0b587cab82 [CS][DX] Refactor
