This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
It's the highest time 🖖
Commits
-------
5bebfc5490 Revert ReflectionExtractor hot-fix
This PR was merged into the 1.12-dev branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.11
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | none
| License | MIT
While in Symfony 5 the `Symfony\Bundle\FrameworkBundle\Templating\EngineInterface` was removed, in Sylius there were still references to that interface in docblock comments.
With Sylius 1.11 ([with this commit](ced91b9bd6)) the type hint has been promoted to a PHP type hint. This normally does not cause any problem because apparently the class loading is lazy and does not try to load the non-existent interface.
But if PHP OPCache preload is used, like suggested [here](https://symfony.com/doc/current/performance.html#use-the-opcache-class-preloading), it appears that PHP switches to eager class loading and you get the following fatal error:
```
NOTICE: PHP message: PHP Fatal error: Failed to load class Symfony\Bundle\FrameworkBundle\Templating\EngineInterface used by typed property Sylius\Bundle\ShopBundle\Controller\SecurityWidgetController::$templatingEngine during preloading in Unknown on line 0
```
With this PR we propose to remove all references to the old interface as Symfony 4 is not supported anymore by Sylius.
Commits
-------
1b555f948d Remove references to old Symfony FrameworkBundle EngineInterface
* 1.11:
Specify explicit priorities for all form type extensions
Small CS fixes
Line length fixes
PHP 8 syntax in bundles vol.2
Typehint templating engines properly
Fix line length issues
PHP 8 syntax in bundles #1
* 1.9:
[ApiBundle] Add README file with testing instructions
[ApiBundle] Remove setting APP_DEBUG variable for PHPUnit
[Api] Refactor fetching id from IRI converter to direct object
[ApiBundle] Move unit tests of test application to src directory
[ApiBundle] Revert changes in RouteNameResolver and PathPrefixProvider
[ApiBundle] Refactor directories and namespaces of test application
[ApiBundle] Update composer in test application
[ApiBundle] Update .gitignore file in test application
[ApiBundle] Simplify configs of test application
Add tests for Taxon and add fixes
Add tests for chceking relations and iris on api resource
Add test and configuration for overwriting apiPlatform resources
Add test for resource type entity
Add test for new not admin api resource by loged admin
Add test entity and api_platform overwriting config
Add test app for ApiBundle
* 1.9:
Change application's version to v1.9.0-DEV
Change application's version to v1.9.0-BETA.3
Generate changelog for v1.9.0-BETA.3
Fix timeout on 404 Not Found errors when using templating and Symfony 4.4
