kenaug74/Sylius
1
0
Fork 0
mirror of https://github.com/Sylius/Sylius.git synced 2026-07-14 17:10:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5
Sylius/features/shipping/managing_shipping_methods
History
Kamil Kokot 05c9e8fc7d
bug #10981 [Behat] Spend less time waiting for slug generation (Zales0123) 
This PR was merged into the 1.7-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | related issues https://github.com/Sylius/Sylius/pull/10973, https://github.com/Sylius/Sylius/pull/10562, https://github.com/Sylius/Sylius/pull/10043
| License         | MIT

Even though waiting for the slug generation should end when it's generated, I've noticed that it still takes a lot of time. So I made a quick experiment with lowering the waiting time and it seems to not harm and even improve execution time a little bit 💃 
I also removed a `@javascript` tag from some scenarios that _de facto_ didn't need it.

Before:

<img width="552" alt="Zrzut ekranu 2019-12-20 o 11 57 30" src="https://user-images.githubusercontent.com/6212718/71250974-57135880-2321-11ea-8e86-ed3d1bb70061.png">

After:

<img width="540" alt="Zrzut ekranu 2019-12-20 o 11 56 12" src="https://user-images.githubusercontent.com/6212718/71251008-698d9200-2321-11ea-9865-99a0bafa9c3c.png">


Commits
-------

c0a4652a5b Remove unnecessary @javascript tag from some scenarios
af99a572be Lower jquery waiting time
2019-12-23 10:25:25 +01:00
..
adding_shipping_method.feature [Behat][Admin][Shipping] Fixes in shipping method after add currency per channel 2016-11-28 18:57:24 +01:00
archiving_shipping_methods.feature [Behat] Scenarios for archiving shipping methods 2017-01-20 15:21:56 +01:00
browsing_shipping_methods.feature [Behat] Be consistent with shipping method naming 2016-11-15 14:57:02 +01:00
deleting_multiple_shipping_methods.feature [Behat] Remove js requirement for bulk delete scenarios 2019-12-19 09:03:04 +01:00
deleting_shipping_method.feature [Behat] Removed the default "EU" zone 2016-08-24 17:05:24 +02:00
editing_shipping_method.feature Remove unnecessary @javascript tag from some scenarios 2019-12-20 08:30:47 +01:00
preventing_deletion_of_used_shipping_method.feature [Behat] Changed scenarios and contexts to depend on the United States channel 2016-08-24 13:38:14 +02:00
shipping_method_code_validation.feature Remove unnecessary @javascript tag from some scenarios 2019-12-20 08:30:47 +01:00
shipping_method_flat_rate_per_shipment_validation.feature PR review fixes 2019-10-24 08:17:01 +02:00
shipping_method_flat_rate_per_unit_validation.feature [ShippingMethod] Do not allow to specify shipping fee below 0 2019-10-23 13:30:43 +02:00
shipping_method_unique_code_validation.feature [Behat][Admin][Shipping] Fixes in shipping method after add currency per channel 2016-11-28 18:57:24 +01:00
shipping_method_validation.feature [Behat] Enable shipping method name validation scenario 2017-09-12 09:41:20 +02:00
sorting_shipping_methods_by_name_or_code.feature [Shipping] Fix sorting after recent changes 2016-10-19 09:55:19 +02:00
sorting_shipping_methods_by_position.feature [Admin] Make shipping methods position update when adding new ones 2016-10-19 09:55:18 +02:00
toggling_shipping_method.feature [Behat] Removed the default "EU" zone 2016-08-24 17:05:24 +02:00