mirror of
https://github.com/Sylius/Sylius.git
synced 2026-07-14 17:10:53 +00:00
f12a530c7f
This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|-----| | Branch? | 1.12 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | fixes #15183 | | License | MIT | Refs video in #15183 When we login in addressing page after submit once the page, the reload process after login resubmit data, and keep sending `form[customer][email]`, that it doesn't be added in form. So I unset these data on pre-submit. I also change the csrf_error message for something more "understandable". By this way, we can still have previous submitted data for address fields.  The other way, suggested by @Wojdylak, is to change this line https://github.com/Sylius/Sylius/blob/1.12/src/Sylius/Bundle/UiBundle/Resources/private/js/sylius-api-login.js#L50 by ``` window.location = window.location.href; ``` But using it, all already filled data are lost. WDYT ? Would it be acceptable to lose such data, or should we keep them ? Commits ------- [Checkout] Prevent extra fields when login in on addressing page Update src/Sylius/Bundle/CoreBundle/Form/Type/Checkout/AddressType.php Add tests that form doesn't display Extra fields error after login in checkout Remove fr translation |
||
|---|---|---|
| .. | ||
| account | ||
| addressing | ||
| admin | ||
| cart | ||
| channel | ||
| checkout | ||
| cli | ||
| contact | ||
| currency | ||
| customer | ||
| homepage | ||
| installer | ||
| inventory | ||
| locale | ||
| order/managing_orders | ||
| payment | ||
| product | ||
| promotion | ||
| shipping | ||
| taxation | ||
| taxonomy/managing_taxons | ||
| user | ||