This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | reactivated #13796
| License | MIT
Commits
-------
Add a support for Symfony Panther in the JS-based Behats
Fix PHPSpec scenario
Add support for Panther to CookieSetter service
Run failing scenarios on Panther with using chromedriver
Bring back the "chrome_headless_second_session" mink session
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|-----|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#15183 |
| License | MIT |
Refs video in #15183
When we login in addressing page after submit once the page, the reload process after login resubmit data, and keep sending `form[customer][email]`, that it doesn't be added in form.
So I unset these data on pre-submit.
I also change the csrf_error message for something more "understandable".
By this way, we can still have previous submitted data for address fields.
The other way, suggested by @Wojdylak, is to change this line https://github.com/Sylius/Sylius/blob/1.12/src/Sylius/Bundle/UiBundle/Resources/private/js/sylius-api-login.js#L50
by
```
window.location = window.location.href;
```
But using it, all already filled data are lost.
WDYT ? Would it be acceptable to lose such data, or should we keep them ?
Commits
-------
[Checkout] Prevent extra fields when login in on addressing page
Update src/Sylius/Bundle/CoreBundle/Form/Type/Checkout/AddressType.php
Add tests that form doesn't display Extra fields error after login in checkout
Remove fr translation
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible)
- Features and deprecations must be submitted against the master branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
bfd58f38e7 Add validation for product meta keywords & description
d44fb803ab Provide Behat scenarios covering validating meta keywords and meta description fields
96586c8c13 Fix CI
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Same issue like [here](https://github.com/Sylius/Sylius/pull/15214)
Commits
-------
92562de372 Fix configuring amount for cart promotions item percentage discount actions
eb13a2969f [Behat][Promotion] Update percentage decimal places tests
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#13749, replaces #13889 |
| License | MIT |
Commits
-------
[Admin][Taxon] Fix slug generation to work based on the parent field
[Behat][Admin][Taxon] Autogenerate slug based on selected parent
[Admin][Taxon] Fallback from parent code to id when generating a slug
This PR was merged into the 1.12 branch.
Discussion
----------
…ctOptionAutocompleteType
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes#13742 |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Before:
After:
Commits
-------
[Admin][ProductOptions] Changed form ProductOptionChoiceType to ProductOptionAutocompleteType
Revert BC breaking changes
minor improvements
Show option name as a choice name instead of code
Fix Main Taxon autocomplete scenarios
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
Commits
-------
[Country] Add violation for adding provinces with duplicated codes
[Behat][Admin][Country] Tests for saving duplicated provinces
Update phpstan baseline
[Country] Additional validation for duplicated provinces names
[Behat][Admin][Country] Validation of saving duplicated province names
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes [#X](https://github.com/Sylius/Sylius/issues/12112) |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
ec4d4d890f Remove usage of defaultLocaleCode from SelectAttributeChoicesCollectionType
fd1834479d Use localeCode in ProductAttribute form to prevent logic from breaking when not using default locale
a959f7c4fc [Behat] Add scenario for checking if attribute is correctly added with values
f297799825 Update upgrade file
a9546e0081 Fix BC Break in SelectAttributeChoicesCollectionType
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes [#X](https://github.com/Sylius/Sylius/issues/15193) |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
it is now possible to configure decimal amounts with comma without validation errors
Commits
-------
e85e30b553 Fix configuring amount for catalog promotions fixed discount actions
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | replaces #13241
| License | MIT
Previously, when an avatar was added while creating a new administrator, once any error occurred, Sylius was throwing `500` due to being unable to create a CSRF token for the delete button.
Commits
-------
b8576ddbda Fix rendering admin creation form with errors
1394309b87 [Behat][Admin] Cover validation errors while adding a new avatar
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | yes
| New feature? | kinda
| BC breaks? | no
| Deprecations? | no
| Related tickets | replaces #12870
| License | MIT |
Currently, when we disable a shipping method, and someone is after the shipping method choice step and has the disabled shipping method selected, they'll be able to place the order. After merging this PR, the customer is going to see
> The "%shippingMethodName%" shipping method is not available, please choose another one.
message.
Commits
-------
f95513cc39 Add behat scenario covering preventing a placing an order with a disabled shipping method
f4603f9eb7 Prevent placing an order with not available shipping method
d70afa1951 Fix static analysis
a267e2ea3e Provide post-CR fixes
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#15151 |
| License | MIT |
Commits
-------
check before refreshing from db
Update OrderController.php with early return
Add behat scenario covering expires session while cart updating
Adjust scenarios to use less technical language
