This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | yes |
| Related tickets | fixes#15547 |
| License | MIT |
This PR fix an issue introduced by #15273.
Variants are by default ordered by position via a specific Doctrine resource configuration :
https://github.com/Sylius/Sylius/blob/1.12/src/Sylius/Bundle/ProductBundle/Resources/config/doctrine/model/Product.orm.xml#L37-L38
This behaviour has to be cloned to retrieve the right variant.
Commits
-------
8e1303e554 Add deprecation notice mention by @diimpp
b2a2b3ea17 mention about service new argument
a48a8c8c0b Add orderBy position and id to get the same sets used on ->getEnabledVariants()
3d72280fa9 Add Scenario to test default variant
6d097ba1c3 Using findBy to avoid PSALM error
10a5de68a2 Update src/Sylius/Component/Product/Resolver/DefaultProductVariantResolver.php
Co-authored-by: Victor Vasiloi <victor.vasiloi@gmail.com>
00297e1593 Fix Spec tests
This PR was merged into the 1.12 branch.
Discussion
----------
Adds if_array check to prevent in_array check on null.
**Issue**
We ran into an error when it tries to do an in_array check where $object->getValue returns null.
**How to reproduce**
* Have an attribute of type SELECT
* Have an attribute value which has json_value NULL
* When trying to normalize the entity it will throw an error because it tries to do an in_array check on null.
Commits
-------
4906accf82 Add if_array check in ProductAttributeValueNormalizer.php
f4fbbf89f5 [API] Improve normalizing value of select attribute
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#15286 |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
06f4fec706 fix(user): make compatible sf6 sylius user to use encoder_name on login
7eba4d0bdd doc: adds note on the PasswordHasherAwareInterface in User class
0d116c6ace Move note about PasswordHasherAwareInterface to the newest patch in the UPGRADE file
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #X, partially #Y, mentioned in #Z |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
c724593223 Update taxation.rst
568d8422bb [Documentation] Minor improvement for note about tax calculators
This PR was merged into the 1.12 branch.
Discussion
----------
I was trying to install the BootstrapTheme, but it wasn't working because the `legacy_mode` part was not documented. Hope it's helpful :)
Commits
-------
24148df10a Update bootstrap-theme.rst
6ba56f8bce Update bootstrap-theme.rst
This PR was merged into the 1.12 branch.
Discussion
----------
Fix links to classes:
src/Sylius/Bundle/CoreBundle/CatalogPromotion/Command/ApplyCatalogPromotionsOnVariants.php src/Sylius/Bundle/CoreBundle/CatalogPromotion/CommandDispatcher/BatchedApplyCatalogPromotionsOnVariantsCommandDispatcher.php
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 or 1.13 <!-- see the comment below --> |
| Bug fix? | no/yes |
| New feature? | no/yes |
| BC breaks? | no/yes |
| Deprecations? | no/yes <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes #X, partially #Y, mentioned in #Z |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
e97c6bd7eb Update catalog_promotions.rst
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | #15527
| License | MIT
[link](https://github.com/Sylius/Sylius/pull/15527#discussion_r1392682435)
Commits
-------
Add ignore parse errors to composer require checker
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | N/A
| License | MIT
Commits
-------
eba08b9042 Disable check for security vulnerabilites step
5a1f03c171 Add a conflict for "doctrine/doctrine-bundle": "2.11.0"
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#15505 |
| License | MIT |
Commits
-------
Fix cart styles after form submission (data-route="sylius_shop_cart_checkout")
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
Commits
-------
[Maintenance] Fix AdminFilterSubscriber failing when no _route attribute present
[Maintenance] Fix other possibly invalid route attribute getting
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
It seems that in our tests we had an outdated way of setting locale
Commits
-------
[Behat] Set a LocaleCode via the HTTP Accept-Language header
This PR was merged into the 1.12 branch.
Discussion
----------
This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yaml).
Commits
-------
cd84b01b83 [CS][DX] Refactor
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#15388 |
| License | MIT |
Commits
-------
54e7f87883 [Fix] Early return in CartCollector on stateless requests
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#12670 |
| License | MIT |
Following what @NoResponseMate suggeste here : https://github.com/Sylius/Sylius/issues/12670#issuecomment-1195216609
This PR applies a `raw` filter to each subject block available in Sylius (CoreBundle).
We can also decode html entities right after the block is rendered, but I don't know if it will break something if someone is using an API to send the email instead of a classic SMTP.
Commits
-------
149da4e31b Use raw filter to avoid html encoded chars in the subject of the each emails
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#13198 and maybe #15282 |
| License | MIT |
Before this PR behaviour:
Given the `%locale%` parameter is set to `en` for example and the available channel locales are different from this locale. When I reach a Payum route like `payum_capture_do` or any other route not beginning with `/{_locale}` and being part of the `shop` firewall.
Then I'm redirected to the homepage.
This PR will avoid redirecting to the homepage if no attribut locale is found in the route.
Commits
-------
813d66c0da Restrict the listener to the routes having _locale attribut
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes#15271 |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
These changes increase admin performance and optimise memory usage.
Commits
-------
19ab3b9cd2 get default variant by id
04712ad53b Update ProductContext
7e04b04cf4 added backwards compatability and deprecation message
844654dce4 fallback to getter if product doesn't have an id
85bd10e675 Remove deprecation from DefaultProductVariantResolver that should be added in 1.13
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no|
| Related tickets | #15395 and #15397|
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
Fix failing phpspec scenario on Symfony 6.3.5 and above
