This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
fix prefix url on locale api path
fix prefix url on order api path
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 or 1.13 <!-- see the comment below --> |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #X, partially #Y, mentioned in #Z |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
Update default Rules of cart promotion
Update docs/book/orders/cart-promotions.rst
Update cart-promotions.rst
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes https://github.com/Sylius/Sylius/issues/15201 |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
In https://github.com/Sylius/Sylius/pull/14932 we introduced a bug that was removing promotion rules after removing product, it was leading to unexpected behaviour which is described [here](https://github.com/Sylius/Sylius/issues/15201), so we decided to prevent removing product/taxon if it is used by promotion rules
Commits
-------
ff0eeb9949 [UI] Prevent removing product if it is already used in promotion rule
2cdb8e8b90 [API] Prevent removing product if it is already used in promotion rule
8431d9bbdf Prevent removing taxon if it is already used in promotion rule
1b8e2e4c17 Adjust configuration
165ba474e5 Update upgrade file
e4a6af47bd [PHPStan] Fix
b1c9f493c3 Update `ProductCannotBeRemoved` message
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible)
- Features and deprecations must be submitted against the master branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
bfd58f38e7 Add validation for product meta keywords & description
d44fb803ab Provide Behat scenarios covering validating meta keywords and meta description fields
96586c8c13 Fix CI
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | closes#12541
| License | MIT
We agreed there is no good way to resolve that issue in `1.x` version, so we decided to make the docs as clear as it's possible in that matter.
P.S. I've created a task for considering how to fix this in later Sylius versions :).
Commits
-------
cc6cde8e6a Add a note about payment-related events
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Same issue like [here](https://github.com/Sylius/Sylius/pull/15214)
Commits
-------
92562de372 Fix configuring amount for cart promotions item percentage discount actions
eb13a2969f [Behat][Promotion] Update percentage decimal places tests
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes#9909, based on #11905
| License | MIT
Basing on #11905 I removed the "feature" part, to merge the "bug-fixing" part into `1.12`. We'll consider later adding "Move top" and "Move end" features, but probably it'll be considered in terms of `2.0` with the new Admin Panel.
Thanks @igormukhingmailcom for your work! I'm happy we're finally going to merge your commits :).
Previously:
Now:
Commits
-------
6ea93e386a Fixed: Moving taxons up and down at admin
f2025429ab Added: Move taxon to the top/end buttons at admin
a1aaac2971 Leave only bug-related code and extract the position-related logic
2f312dbded Revert bc promise breaking changes
a2eeee131a Cover "jumping" taxons while moving with Behat scenarios
c331d61281 Remove redundant TaxonPositioner service
b4bfdf3a7d Provide post-CR fixes
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
Some time ago I encountered several issues with the CheckoutResolver failing because of some assumptions that were not met by my customizations. Unfortunately, I can't remember the context.
This PR makes it fail safe in case those assumptions are not met and covers it with PHPSpec tests.
Commits
-------
5154b81cff make CheckoutResolver fail safe
3e1b62bb6d CheckoutResolver should not run on routes other than shop checkout
678bd672f9 [Maintenance] Note checkout pattern update
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | closes#10313
| License | MIT
Commits
-------
529678ecce Prevent throwing 500 while finalizing an order when at least one item has become tracked
f8a5b221d9 Add a scenario covering finalizing order's payment when a one item has become tracked
