This PR was merged into the 1.13 branch.
Discussion
----------
This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yaml).
Commits
-------
[CS][DX] Refactor
This PR was merged into the 1.14 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.14
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 1.13 branch
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
[CI] Update Sylius branches in refactor workflow
This PR was merged into the 1.13 branch.
Discussion
----------
This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yaml).
Commits
-------
1a7bf27bc0 [CS][DX] Refactor
* 1.13:
[Behat] Switch another random JS failed scenarios to Chromedriver
[Behat] Switch another random JS failed scenarios to Chromedriver
[Behat] Switch random JS failed scenarios to Chromedriver
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.13
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 1.13 branch
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
[Behat] Switch random JS failed scenarios to Chromedriver
[Behat] Switch another random JS failed scenarios to Chromedriver
[Behat] Switch another random JS failed scenarios to Chromedriver
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.13
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | replaces #16816
| License | MIT
<!--
- Bug fixes must be submitted against the 1.13 branch
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
77ca7f4afe [PHPStan] Support both sylius/resource-bundle 1.10 and 1.11
a4f2a50a69 [Taxonomy] Fix Taxon spec
597fafc33d Minor improvements in PHPStan configuration
* 1.13:
Minor CS fix in workflow
[Resource] Add validation for translatable interface with new namespace
Apply suggestions from code review
Both resource and grid unstable versions
Try SyliusGridBundle 1.13
[Core] Move validation of translation classes to Core
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Inspired by #15119
Commits
-------
Try SyliusGridBundle 1.13
Both resource and grid unstable versions
Apply suggestions from code review
[Resource] Add validation for translatable interface with new namespace
Minor CS fix in workflow
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.13
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | extracted from #15706
| License | MIT
This is a change to allow support for SyliusResourceBundle 1.11 (and older), where this validation has just been added globally on `AbstractTranslation`. PR with enabled tests: #15706.
<!--
- Bug fixes must be submitted against the 1.13 branch
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
[Core] Move validation of translation classes to Core
This PR was merged into the 1.14 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.14
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Related tickets | #16757
| License | MIT
<!--
- Bug fixes must be submitted against the 1.13 branch
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
[Money] Deprecate unneeded templating helpers
This PR was merged into the 1.13 branch.
Discussion
----------
This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yaml).
Commits
-------
[CS][DX] Refactor
* 1.13:
Change application's version to v1.13.6-dev
Generate changelog for v1.13.5
Change application's version to v1.13.5
Fixing customer order view
[BC-Break][1.13] Do not enforce soft method requirement on ProductVariantPricesCalculatorInterface
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.13
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
While testing out https://github.com/Brille24/SyliusTierpricePlugin, I've encountered 500 errors when trying to access the product detail page. This is because even tho the `calculateLowestPriceBeforeDiscount` method has a soft requirement on `Sylius\Component\Core\Calculator\ProductVariantPricesCalculatorInterface`, it is used in several classes and therefore enforced. This PR fixes that with checks if the method exists.
I had to use PHPUnit tests to ensure the correctness of this fix, as PHPSpec, by default, treats methods declared in doc block as defined on the class.
Commits
-------
55759bb09d [BC-Break][1.13] Do not enforce soft method requirement on ProductVariantPricesCalculatorInterface
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.13
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes#15132
| License | MIT
In the Pull request linked above @jakubtobiasz configured repository method was changed to also require a criteria argument (of type array). Which resulted in this:
The reason for this is despite the fact that it looks like they're being passed as named arguments from the config, the grid bundle does an `array_values` on the array to throw away the keys. This PR fixes that and just passes a default value for the criteria.
## Steps to reproduce
* Create a customer
* Go to the customers details page in the admin
* Click on "Show orders"
* See creash
Commits
-------
40d973f9a7 Fixing customer order view
This PR has been generated automatically.
For more details see
[upmerge_pr.yaml](/Sylius/Sylius/blob/1.13/.github/workflows/upmerge_pr.yaml).
**Remember!** The upmerge should always be merged with using `Merge pull
request` button.
In case of conflicts, please resolve them manually with usign the
following commands:
```
git fetch upstream
gh pr checkout <this-pr-number>
git merge upstream/1.14 -m "Resolve conflicts between 1.13 and 1.14"
```
If you use other name for the upstream remote, please replace `upstream`
with the name of your remote pointing to the `Sylius/Sylius` repository.
Once the conflicts are resolved, please run `git merge --continue` and
push the changes to this PR.
This PR was merged into the 1.14 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.14
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | #16703
| License | MIT
Commits
-------
[Admin] Fix resending order confirmation emails
This PR was merged into the 1.14 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.14
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
We are changing the referrers to static routes where appropriate to make the code more streamlined and predictable.
Commits
-------
dc61d08b21 [Maintenance] Less referrer usage in static redirects
c2fe0de635 Add a note to UPGRADE file about ResendOrderConfirmationEmailAction constructor change
30268e3b99 Fix builds after referrers refactor
