This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
Commits
-------
210754fe1a Add a conflict for "stof/doctrine-extensions-bundle": "1.8.0"
* 1.12:
Refactor to provide a product translation instead of generate product shop url
Provide post-CR fixes
Allow passing a desired locale code to DefaultChannelFactory
Remove unknown localeCode named paramter
Add support for secure and unsecured URLs for generating product show page
Refactor logic behind a button redirecting to the product's shop page
Adding try logic to get the shop's slug
Adding default if product has no slug
[Bunnyshell] Adjust the workflows for Fork PRs
[Maintenance] Improve ProportionalIntegerDistributor to keep original index
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | replaces #14663
| License | MIT
Commits
-------
d24183f65b Adding default if product has no slug
98d853eb13 Adding try logic to get the shop's slug
9856b1e62f Refactor logic behind a button redirecting to the product's shop page
a394383457 Add support for secure and unsecured URLs for generating product show page
60000de780 Remove unknown localeCode named paramter
bfb011d84e Allow passing a desired locale code to DefaultChannelFactory
cf86d245b6 Provide post-CR fixes
ae721b5bd4 Refactor to provide a product translation instead of generate product shop url
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | n/a
| License | MIT
CI fails on branches based on `1.12.` as there's no `.bunnyshell` dir on `1.12`.
Commits
-------
[Bunnyshell] Adjust the workflows for Fork PRs
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | somewhat |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
Commits
-------
[Maintenance] Improve ProportionalIntegerDistributor to keep original index
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 <!-- see the comment below --> |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | https://github.com/Sylius/Sylius/pull/15064
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
[PHPStan] Add missing @param annotations
[ECS] Apply ecs fixes
[Units] Adjust checkout completion responses
* 1.12:
[PostgreSQL] Handle DriverException gracefully with 22P02 SQLState
[Orders][Shop] Improve order item quantity change validation
[Unit][Orders] Add tests for items quantity change
[Orders][Shop] Add checkout completion validation
[Unit][Orders] Add tests for checkout completion
[Unit][Orders] Add tests for preventing from order completion
[Orders][Shop] Add shipment validation when trying to assign shipping method
[Unit][Orders] Add test for validating shipmentId when trying to assign shipping method
[Unit][Utils] Introduce ContentType helper class
[Orders] Add missing order payment configuration endpoint validation
[Unit][Orders][Shop] Add test for validation invalid payment param
[Unit][Orders][Shop] Add test for invalid uri param validation
[Unit][Orders][Shop] Extract helper methods
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 and 1.13 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | https://github.com/Sylius/Sylius/issues/14764 |
| License | MIT |
We are missing validation of the order checkout process and some URI parameters across order endpoints
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
4bfbb8e38e [Unit][Orders][Shop] Extract helper methods
8363d0d3c3 [Unit][Orders][Shop] Add test for invalid uri param validation
500bf9479e [Unit][Orders][Shop] Add test for validation invalid payment param
0d37303cc4 [Orders] Add missing order payment configuration endpoint validation
7f36b7e3fb [Unit][Utils] Introduce ContentType helper class
5161355453 [Unit][Orders] Add test for validating shipmentId when trying to assign shipping method
5dc183e1b1 [Orders][Shop] Add shipment validation when trying to assign shipping method
a5f7c232dd [Unit][Orders] Add tests for preventing from order completion
8606840507 [Unit][Orders] Add tests for checkout completion
f9e83a7543 [Orders][Shop] Add checkout completion validation
0268c02a7f [Unit][Orders] Add tests for items quantity change
020cc54064 [Orders][Shop] Improve order item quantity change validation
b234f36de6 [PostgreSQL] Handle DriverException gracefully with 22P02 SQLState
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
Attempt to solve the issue of decimal values being lost during tax calculation on item level which leads to a wrong tax total at the order level.
Issue reported by @ikamikaz3 via Slack ([full thread](https://sylius-devs.slack.com/archives/C3EGDG9LY/p1648827780599519)):
Commits
-------
65b720e8b9 Calculate tax with decimal precision and distribute proportionally across order items
0921db1b03 [Behat] Add scenarios for calculating tax with decimal precision for multiple items
9bf7d8e259 [Taxation] Fix service definition of DecimalCalculator
1cdca39e5c Add new distributing logic to OrderItemsTaxesApplicator optional
b3caf45aa4 [Documentation] Add info about new decimal tax calculator to docs
dea2fb8406 Prevent iterating over non-existent indexes
25b270fa8c Improve iterating over items and units during taxes application
a43f92d199 Extract checking items quantities before calculations in OrderItemsTaxesApplicator
a4af0f8897 Add missing spec for OrderItemsTaxesApplicator
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
[Bunnyshell] Adjust the workflows for Fork PRs
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 <!-- see the comment below --> |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
Endpoints that dispatches commands, do not have proper validation and expose business logic. This PR solves it with a validator.
Before:
<img width="1727" alt="image" src="https://github.com/Sylius/Sylius/assets/40125720/c61ce5f5-ab45-4e28-a27c-d37bfa45c288">
After:
<img width="1435" alt="image" src="https://github.com/Sylius/Sylius/assets/40125720/6a71fe62-880a-4e0a-84b3-28aea812ffe2">
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
b644746561 [Unit][ProductReviews] Add contract test for POST review payload validation
6f6bf56a4d [API][ProductReview] Validate product field
09a5b65424 [API] Change the constructor signature of the AddProductReview command
84669f413b [Unit][Orders] Add tests for adding items to the cart validation
2876f9ba43 [API] Change the constructor signature of the AddItemToCart command
8b1dce2e4b [API][Orders] Validate adding items to the cart
a6df3c94a9 [Maintenance] Use property promotion in commands
aafc207537 [Unit][Orders] Add test for changing item quantity of the cart
0ab079e14e [API] Change ChangeItemQuantityInCart command methods signatures
200ea9e3e6 [API][Orders] Validate item quantity change
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13
| Bug fix? | no/
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | closes#14781
| License | MIT
Commits
-------
84738dde94 Add joins on the orders list conditionally
6bb765d7c6 Fix broken displaying customer's orders in the admin panel
