* 1.14:
Change application's version to v1.12.19-dev
Generate changelog for v1.12.18
Change application's version to v1.12.18
Update repository.rst
Update model.rst
* 1.13:
Change application's version to v1.12.19-dev
Generate changelog for v1.12.18
Change application's version to v1.12.18
Update repository.rst
Update model.rst
This PR was merged into the 1.13 branch.
Discussion
----------
fix typo
| Q | A
|-----------------|-----
| Branch? | 1.12, 1.13, 1.14 or 2.0 <!-- see the comment below -->
| Bug fix? | no/yes
| New feature? | no/yes
| BC breaks? | no/yes
| Deprecations? | no/yes <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | fixes #X, partially #Y, mentioned in #Z
| License | MIT
<!--
- Bug fixes must be submitted against the 1.12 or 1.13 branches
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
cfcbd05dec Update repository.rst
This PR was merged into the 1.13 branch.
Discussion
----------
fix typo
| Q | A
|-----------------|-----
| Branch? | 1.12, 1.13, 1.14 or 2.0 <!-- see the comment below -->
| Bug fix? | no/yes
| New feature? | no/yes
| BC breaks? | no/yes
| Deprecations? | no/yes <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | fixes #X, partially #Y, mentioned in #Z
| License | MIT
<!--
- Bug fixes must be submitted against the 1.12 or 1.13 branches
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
74a900caa8 Update model.rst
* 1.14:
Minor fixes after PR review
Fix products grid for mobile
Update PR template
[Documentation] Update Sylius 1.12 version on the release cycle page
Add upmerge from 2.0 to symfony-7 branch
Fix ProductTaxons' positioning logic
* 1.13:
Minor fixes after PR review
Fix products grid for mobile
Update PR template
[Documentation] Update Sylius 1.12 version on the release cycle page
Fix ProductTaxons' positioning logic
* 1.12:
Minor fixes after PR review
Fix products grid for mobile
Update PR template
[Documentation] Update Sylius 1.12 version on the release cycle page
Fix ProductTaxons' positioning logic
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | outlined in https://github.com/Sylius/Sylius/pull/15225#issuecomment-1790825230
| License | MIT
The second issue:
>The other error is smaller, the count should not be reduced by 1 because the positioner will check for $newPosition >= $maxPosition. If you move a product to the last one in the taxon it will change it to the second-last position.
does not occur since when the `$newPosition >= $maxPosition` check is true, the position is set to `-1` instead of being reduced by 1. After that, the default Gedmo logic kicks in and `-1` gets converted into the last position.
Commits
-------
4fa32f324c Fix ProductTaxons' positioning logic
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 1.12 or 1.13 branches
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
[Documentation] Update Sylius 1.12 version on the release cycle page
Update PR template
Minor fixes after PR review
This PR was merged into the 1.14 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 2.0 -->
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 1.12 or 1.13 branches
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
3374d90803 Add upmerge from 2.0 to symfony-7 branch
