This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | yes? |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#14229 |
| License | MIT |
Clicking the cart button when the screen cannot accommodate the popup will now redirect to the cart instead of throwing a console error and doing nothing.
Commits
-------
aa2d054810 [UX] Fix cart button on small screens
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | #14661 |
| License | MIT |
Commits
-------
d718751f68 [Maintenance] Remove Doctrine's LifecycleEventArgs deprecations
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
Commits
-------
5ba04c0534 It's 2023!
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.11
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes#13688, replaces #12762 and #12286
| License | MIT
Credits to @DennisdeBest and @antiseptikk for the previous PRs and to @AymLaf for the reminder.
Commits
-------
6ebbc411d7 Fix typo in sylius_order state machine callback
1260a85012 Add deprecation notice and BC layer
d3e76eb38b Add unit test for CancelOrderStateMachineCallbackPass
bf5838f43c Add convertDeprecationsToExceptions to Core Bundle's phpunit config
3ee618ceaf Add the ability to install jms/serializer-bundle:^4.0 version
96cdffefee Fix static checks
5fabb8377c [Hot-fix] Do not fail scenario after 422 response page
This PR was merged into the 1.11 branch.
Discussion
----------
This PR has been generated automatically.
For more details see [refactor.yml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yml).
Commits
-------
325d8976f7 [CS][DX] Refactor
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes/closes #11145 |
| License | MIT |
Previously when loading taxons we've been performing plenty of queries due to lazy loading. Changing fetch mode to eager seemed not to work, and also wasn't a desired solution. Two-step hydration instead solved the problem.
I am unable to include "before" results as debug toolbar can't finish loading :|. So as reference, let's use the screenshots from #11145. For 5000 taxons we were executing about ~12.000 queries (it depends on the level of nesting and other factors). For 1000 taxons locally, I've got about 2.000 queries.
Here are the results for 2.000 taxons (in the shop enabled is about 1/3 of that):
Admin Panel:
<img width="159" alt="CleanShot 2022-12-21 at 12 55 37@2x" src="https://user-images.githubusercontent.com/80641364/208899596-1b02c50c-2ecc-48f5-ac1d-f76d56d4c6aa.png">
Shop:
<img width="141" alt="CleanShot 2022-12-21 at 12 56 04@2x" src="https://user-images.githubusercontent.com/80641364/208899679-949d89ea-6691-42f0-ad52-805d7011d6cc.png">
Commits
-------
8ce40d23d5 Add two-step hydration when querying taxons
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | [ticket](https://github.com/Sylius/Sylius/pull/14133) |
| License | MIT |
Commits
-------
981951509a Disassociate OrderItemUnit from all shipments before removal
3889e688a9 add spec
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.11 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file -->
| License | MIT
<!--
- Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
- Features and deprecations must be submitted against the master branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
b71a67aa25 Fix sprintf parameters order
9f4f4b1677 Update AvailableProductOptionValuesResolverSpec.php
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.11
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| License | MIT
Commits
-------
c5f9458ecd Add missing space to taxes <tr>
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 and 1.12<!-- see the comment below --> |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes <!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
Reference:
https://github.com/doctrine/orm/releases/tag/2.14.0
<!--
- Bug fixes must be submitted against the 1.11 or 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
f3b294bc59 [Maintenance][Psalm] Add Doctrine\ORM\Event\LifecycleEventArgs to deprecated classes
a2710242de [PHPStan] Exclude Sylius\Bundle\CoreBundle\Doctrine\DQL\Month class
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | [ticket](https://github.com/Sylius/Sylius/pull/13741/files) |
| License | MIT |
Commits
-------
daba045e67 Validate existence of coupon
6a2515a4bf add test
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes https://github.com/Sylius/Sylius/pull/14600 |
| License | MIT |
See the discussion: https://github.com/Sylius/Sylius/pull/14600#issuecomment-1351053306
Commits
-------
1cc89537f1 [ProductAssociation] Fix empty product associations
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | - |
| License | MIT |
"Implementing" suggestion from @GSadee.
Commits
-------
28a469e459 Move Upgrade API from 1.11.11 to 1.11.12 section to the top of file
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes#14391 |
| License | MIT |
So far, on production environment when any non-validation related error occurred, the `FOS\RestBundle\Serializer\Normalizer\FlattenExceptionHandler` was used, even on API Platform endpoints. Now, depending on the path of the request, the `FOS\RestBundle\Serializer\Normalizer\FlattenExceptionHandler` or `ApiPlatform\Hydra\Serializer\ErrorNormalizer` is used.
Commits
-------
1203a7a36c Fix invalid API errors normalization
af04cc897d Fix wrong API's errors normalizer
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 |
| Bug fix? | I consider memory leaking as a bug |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
This PR focus on optimization, not changing the observable behavior, so it doesn't touch command itself, only the service. Moreover, I would like to thank @vvasiloi for helping with this enhancement. The idea of output changes can be implemented (like in Victor's POC #14569), but I believe it should be done later, and in a separate PR.
Commits
-------
cf7e29b4f8 Optimize memory usage by sylius:remove-expired-carts command
f88b9fdfe2 Merge branch '1.11' into maintenance/optimize-carts-removing
c8100505e2 Change a default value of limit in findCartsNotModifiedSince to null
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
EditorConfig from the root directory forces us to use 2 indents but in tests, we use 4 instead.
Commits
-------
7748c854f5 [DX] Add .editorconfig for test API responses
This PR was merged into the 1.11 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.11 or 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
While upgrading to Sylius 1.11 I came across this issue where these migrations were executed but I hadn't set the `MESSENGER_TRANSPORT_DSN` environment variable yet.
This resulted in a diff on my database after I added the variable.
By using the `skipIf()` for these migrations will not be executed, it will just give a notice:
```
[notice] Migration Sylius\Bundle\CoreBundle\Migrations\Version20220203115813 skipped during Execution. Reason: "MESSENGER_TRANSPORT_DSN was not found or is not using Doctrine"
[notice] Migration Sylius\Bundle\CoreBundle\Migrations\Version20220407131547 skipped during Execution. Reason: "messenger_messages table was not found"
```
They keep getting skipped on future runs, however when you add the environment variable they will be executed and only then.
Commits
-------
b60b6190f4 Adding skipIf for migrations to allow future runs when they should apply
This PR was merged into the 1.11 branch.
Discussion
----------
In the `ProductVariantDocumentationNormalizer`, the `price` and `originalPrice` properties have a manual configuration pushed to the array. In this config, `type` is defined as `int`. The issue here is that `int` is not a valid OpenApi data type.
The same issue occurs with the `price` property in `ShippingMethodDocumentationNormalizer`.
This fix simply changes `int` to `integer` for the above three properties.
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.11 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.11 branch
- Features and deprecations must be submitted against the 1.12 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
c7c0bf2b7f [Api] Change int to integer in ProductVariant and ShippingMethod documentation normalizers
