This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | revert changes from https://github.com/Sylius/Sylius/pull/13244
| License | MIT
<!--
- Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
- Features and deprecations must be submitted against the master branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
caf9f0d825 [API] Revert changes of checked keys in cart and checkout responses to fix the build
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | https://github.com/Sylius/Sylius/pull/13252#issuecomment-953665585
| License | MIT
<!--
- Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
- Features and deprecations must be submitted against the master branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
cc66b79e3a [Maintenance] Add note about doctrine/dbal requirement
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
~Psalm complains about it after upgrading liip/imagine-bundle to 2.7. We should probably think about bumping the bundle's version and using the new configuration soon~
EDIT: I conflict with `liip/imagine-bundle:^2.7` for now, due to some other problems. Thanks, @mynameisbogdan for the suggestion 🖖
Commits
-------
d71406f47c Conflict liip/imagine-bundle ^2.7
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | mentioned in https://github.com/Sylius/Sylius/pull/13215#pullrequestreview-790562436
| License | MIT
<!--
- Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
- Features and deprecations must be submitted against the master branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
cb7cac8788 [Maintenance] Replace dbal conflict with explicit requirement
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9, 1.10
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes#13211
| License | MIT
See #13211 and #13214 for more details about the `json_array` type error.
Commits
-------
4466a76b5f Add conflict with doctrine/dba ^3 to avoid missing json_array type error
b7b7095432 Merge branch '1.9' into constraint-doctrine-dbal
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9 1.10
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| License | MIT
Commits
-------
397a054652 Require the json extension as dev dependency as the tests use json_decode()
ba6780d3c5 Checking hydra description key instead of message key
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes#12859
| License | MIT
Commits
-------
dedb5624be BUGFIX: #12859 Fix link to ResourceController in documentation
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
- Features and deprecations must be submitted against the master branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
e5b05e7dde [Maintenance] Bump node version in CI
abe0677535 [Maintenance] Bump node version in CI to v14
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | #13165
| License | MIT
<!--
- Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
- Features and deprecations must be submitted against the master branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
82d459819e [HotFix] Update conflict to doctrine/orm to fix the problem with creating taxons
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
Commits
-------
312746312e [HotFix] Add conflict to doctrine/orm to fix the problem with creating taxons
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
After addressing the empty cart and adding an item to it, there is a cart with some products but payment_skipped as payment state 💃 *In theory*, it's not a problem, as after completion payment state is correct (awaiting payment), but if anything happens about payment before checkout completion, it can lead to some nasty errors. And, conceptually, addressing empty cart does not seems as something correct 🚀
Commits
-------
10e6645c61 Describe bug with Behat scenario
724ac5be72 Include validation on AddressCart command
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.10
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
I got this error during the development of a cart related feature:
```
Symfony\Component\Form\Exception\LogicException:
Cannot check if an unsubmitted form is valid. Call Form::isSubmitted() before Form::isValid().
at vendor/symfony/form/Form.php:752
at Symfony\Component\Form\Form->isValid()
(vendor/sylius/sylius/src/Sylius/Bundle/OrderBundle/Controller/OrderController.php:83)
at Sylius\Bundle\OrderBundle\Controller\OrderController->saveAction(object(Request))
(vendor/symfony/http-kernel/HttpKernel.php:157)
at Symfony\Component\HttpKernel\HttpKernel->handleRaw(object(Request), 1)
(vendor/symfony/http-kernel/HttpKernel.php:79)
at Symfony\Component\HttpKernel\HttpKernel->handle(object(Request), 1, true)
(vendor/symfony/http-kernel/Kernel.php:199)
at Symfony\Component\HttpKernel\Kernel->handle(object(Request))
(public/index.php:25)
```
This PR fixes that.
We _could_ update all controllers with the same fix but right now I prefer to change only this one since I know the behavior.
Commits
-------
8d37b493c7 Check if the form is submitted before validation
This PR was merged into the 1.9 branch.
Discussion
----------
In my projects I tend to use YAML for the configuration files so I thought it might be helpful to others to add configuration examples in the YAML format
| Q | A
| --------------- | -----
| Branch? | 1.9, 1.10 or master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
Commits
-------
d81eb2b17b Add yaml configuration examples
d81f3f1e6b Fix codeblock notations, remove commads
This PR was merged into the 1.9 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.9
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? |
| Related tickets |
| License | MIT
Fixed path to logo template file
Commits
-------
a50af8700a corrected path to logo template and overridden file code
c1c21a74d0 [Docs][Getting started with Sylius] Logo customization - review fixes
