This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | n/a
| License | MIT |
Commits
-------
acfc256b57 Update BuildTestApp actions within workflows
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| License | MIT
The `bin/console sylius:install` command ends with the following error when using the PostgreSQL database:
<img width="1660" alt="image" src="https://user-images.githubusercontent.com/40125720/231223850-5f44fb63-4fa2-4799-828b-2cd8f65774b6.png">
Commits
-------
b4cb9e7702 [Migrations] Check MySqlPlatform class existance case-sensitive
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
Commits
-------
628a131be1 Silence Http\Message\MessageFactory deprecation report
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | n/a
| License | MIT
This reverts commit de58169f58.
Commits
-------
057960f4ac Revert "Add conflict for doctrine/orm:2.14.2"
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
Hello everyone 👋
While browsing our order processors, I figure out that they lack some extendability regarding whether they should be run or not. Most of them have hardcoded check if the `$state` is `cart` - which is a good default behavior, but does not have to be right for everyone (imagine we have a `draft` order, that we still want to process, but is not placed yet). If we want to change that, we would have to override the whole processor just to adjust/remove a simple if at the beginning.
I think such information (whether the order is processable or not) can be a part of the `Order` entity itself. It's easy to override and we avoid some additional services. We could even go further and have other methods like this for specific cases, but let's start simple.
I believe the general rule of thumb regarding the DX and extendability should be "never use any primitive value directly in the condition in any service" (constant is also a value, as it's not easily replaceable 💃).
Cheers 🚀🖖
Commits
-------
c19bb1d15b Determine Order being processable on itself
15a38eafb7 Do not hardcode checking cart state in processors
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| License | MIT
Commits
-------
de58169f58 Add conflict for doctrine/orm:2.14.2
This PR was merged into the 1.12 branch.
Discussion
----------
This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yaml).
Commits
-------
5fed4db64e [CS][DX] Refactor
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 and 1.13 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
It runs `composer validate` after `composer update` and handles the case of already created directories
Commits
-------
b9d2233b07 [Tasks] Improve Robo task
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes#12339
| License | MIT
<!--
- Bug fixes must be submitted against the 1.7 or 1.8 branch (the lowest possible)
- Features and deprecations must be submitted against the master branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
0f62196135 [Product][Association] Fix attaching association with numeric code
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | none |
| License | MIT |
- Bug fixes to load chart.js
Seen information on the documentation of chart.js: https://www.chartjs.org/docs/latest/getting-started/integration.html#quick-start
Commits
-------
150a1496d0 Update sylius-chart.js
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#11679, related #7819 |
| License | MIT |
Commits
-------
4fade40420 [Order] Prevent paying with a disabled method
b90f6ddbc1 [Maintenance][CI] Prevent setup errors when using symfony commands with no db connection
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | kinda
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | n/a
| License | MIT
Since ApiPlatform `2.7` it loads resources' paths on its own. However, prepending comes **after** the paths detected by ApiPlatform. We don't have to remove it to keep support for lower versions of ApiPlatform (but we can remove prepending on `1.13` as we support only `2.7` and above).
By removing the trailing `/` we resolve the issue with duplicated path, as it'll be removed when already added.
After applying my patch:
Commits
-------
60079fb1c8 Change the ApiPlatform Mapping prepend path
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 and 1.13 <!-- see the comment below --> |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
Symfony's changelog: https://github.com/symfony/framework-bundle/compare/v6.2.7...v6.2.8#diff-51cca25b9f344e04d253bf67d646ddaf82a361541effdf554dce3f6d2080dc66R76-R78
Commits
-------
3805e7eb75 [Conflict] Add conflict with symfony/framework-bundle:6.2.8
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | n/a
| License | MIT
The unstable build is run on every PR, but any error is silent, so you have to check manually whether it doesn't fail with the upcoming releases of packages. I left this option mainly because we want an easy way to check whether our fix works.
Also, I run the unstable build on our full build (executed once per day), where the errors are reported, so we'll know that some of the upcoming release of packages may fail with Sylius.
Commits
-------
87927712ac Add experimental builds to CI
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes https://github.com/Sylius/Sylius/actions/runs/4529570438/jobs/7977521181 |
| License | MIT |
It is not handled by the `OrderByIdentifierSqlWalker` because these queries are generated by `Doctrine\ORM\Persisters\Entity\EntityPersister`. I've added `ORDER_BY` to fix the issue. The other way to fix it is to use `createQueryBuilder` instead.
Commits
-------
7212ed57f4 [Channel] Add "order by" to the "find by" methods
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
Commits
-------
9cd314ec09 [Admin][ProductVariant] Switched list rendering from base locale to current
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#14883 |
| License | MIT |
Commits
-------
69c2f8b41b fix: err on using scss var directly inside `calc()` func; resolves Sylius#14883
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | port of #14871
| License | MIT
The initial idea was to upmerge changes from `1.11` but while reviving CI we decided to no more upmerge `1.11` to `1.12`. That's why I had to port changes from #14871 manually.
Commits
-------
40beab69f5 Fix dependency security vulerability for enshrined/svg-sanitize package
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes#14723, successor of #14795
| License | MIT
Commits
-------
4cb0a52599 Prevent the cart recalculation when the form has errors
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | n/a
| License | MIT
Small improvement, useful when 500 occurs on a Behat run.
Commits
-------
58c73cf0bb Add var/log directory to artifacts on pipeline fail
