This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.13
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | N/A
| License | MIT
Commits
-------
Refactor GUS info
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.13
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | #14786
| License | MIT
Commits
-------
Fix Full CI to run 2.0
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.13
| Bug fix? | no
| New feature? | no
| BC breaks? | no/
| Deprecations? | no
| Related tickets | [action](https://github.com/Sylius/Sylius/actions/runs/10086616660/job/27889633254)
| License | MIT
Fixed intermittent test failures in GitHub Actions
Commits
-------
[ChannelsTest] Use inArray to check locales
This PR was merged into the 1.13 branch.
Discussion
----------
Using the callback wrapper to resolve the LocaleChoiceType keeping old entity objects during tests where both the form is build and submit through the Symfony PhpUnit WebTestCase.
Also see https://github.com/Sylius/Sylius/issues/16572
| Q | A
|-----------------|-----
| Branch? | 1.13
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes #https://github.com/Sylius/Sylius/issues/16572
| License | MIT
Commits
-------
fix(locales): use callback wrapper for choices
Remove unused argument
Revert "Remove unused argument
"
Removing the unused $options argument for the variable is not used in the function.
Co-authored-by: Rafał Jaskulski <40125720+Rafikooo@users.noreply.github.com>
* 1.12:
[API] Add note about disabling adjustment GET endpoint to UPGRADE file
[API] Remove unnecessarily added HeadersBuilder class
Add phpunit test
Disable adjustments shop API endpoint
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 1.13 branch
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
de2dec6dbf Disable adjustments shop API endpoint
37f812d825 Add phpunit test
61c984228a [API] Remove unnecessarily added HeadersBuilder class
a9c2ff77bb [API] Add note about disabling adjustment GET endpoint to UPGRADE file
This PR was merged into the 1.13 branch.
Discussion
----------
This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yaml).
Commits
-------
3135b91fe3 [CS][DX] Refactor
I always didn't like behat errors like:
Given I have product "Xxxx" in the cart
(FriendsOfBehat\PageObjectExtension\Page\UnexpectedPageException)
Not informative. Is it unexpected page (i.e. wrong page opened)? Or is
it unexpected exception?
Now it shows:
Is not open: Could not open the page:
"http://localhost:8080/en_US/products/xxx". Received an error status
code: 500 {"slug":"xxx"}
(FriendsOfBehat\PageObjectExtension\Page\UnexpectedPageException)
Feel free to improve or change this commit.
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.13 (1.12 would be nice too) |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | ? |
| Deprecations? | no? |
| Related tickets | none |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the
documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Using the callback wrapper to resolve the LocaleChoiceType keeping old entity objects during tests where both the form is build and submit through the Symfony PhpUnit WebTestCase.
Also see https://github.com/Sylius/Sylius/issues/16572Fixes#16572
This PR was merged into the 1.13 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.13 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file -->
| License | MIT
It appears that these scenarios were not taken into account in our CI.
Commits
-------
0182292e5b [Behat] Enable accessing product edit page from show page scenarios
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.12 <!-- see the comment below -->
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | https://github.com/Sylius/Sylius/pull/11339/files#diff-a07e09d99a1e7ba91cfa0916f49ff948d56676286e28e7cb31b53bfe258bb11eR13
| License | MIT
<!--
- Bug fixes must be submitted against the 1.13 branch
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
5dfe52c8a8 [Docs] Update taxon-menu page to reflect current fixtures configuration
This PR was merged into the 1.13 branch.
Discussion
----------
To allow decorate response checker for custom error messages and so.
| Q | A
|-----------------|-----
| Branch? | 1.14
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| License | MIT
Commits
-------
fe8300c661 Use interface for a response checker dependency
This PR was merged into the 1.13 branch.
Discussion
----------
fix typo
| Q | A
|-----------------|-----
| Branch? | 1.12, 1.13, 1.14 or 2.0 <!-- see the comment below -->
| Bug fix? | no/yes
| New feature? | no/yes
| BC breaks? | no/yes
| Deprecations? | no/yes <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | fixes #X, partially #Y, mentioned in #Z
| License | MIT
<!--
- Bug fixes must be submitted against the 1.12 or 1.13 branches
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
cfcbd05dec Update repository.rst
This PR was merged into the 1.13 branch.
Discussion
----------
fix typo
| Q | A
|-----------------|-----
| Branch? | 1.12, 1.13, 1.14 or 2.0 <!-- see the comment below -->
| Bug fix? | no/yes
| New feature? | no/yes
| BC breaks? | no/yes
| Deprecations? | no/yes <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | fixes #X, partially #Y, mentioned in #Z
| License | MIT
<!--
- Bug fixes must be submitted against the 1.12 or 1.13 branches
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
74a900caa8 Update model.rst
* 1.12:
Minor fixes after PR review
Fix products grid for mobile
Update PR template
[Documentation] Update Sylius 1.12 version on the release cycle page
Fix ProductTaxons' positioning logic
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | outlined in https://github.com/Sylius/Sylius/pull/15225#issuecomment-1790825230
| License | MIT
The second issue:
>The other error is smaller, the count should not be reduced by 1 because the positioner will check for $newPosition >= $maxPosition. If you move a product to the last one in the taxon it will change it to the second-last position.
does not occur since when the `$newPosition >= $maxPosition` check is true, the position is set to `-1` instead of being reduced by 1. After that, the default Gedmo logic kicks in and `-1` gets converted into the last position.
Commits
-------
4fa32f324c Fix ProductTaxons' positioning logic
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
|-----------------|-----
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets |
| License | MIT
<!--
- Bug fixes must be submitted against the 1.12 or 1.13 branches
- Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted against the 2.0 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
[Documentation] Update Sylius 1.12 version on the release cycle page
Update PR template
Minor fixes after PR review
