This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A
| --------------- | -----
| Branch? | 1.11
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| License | MIT
Following this PR: #13708
Commits
-------
[Locale] Change language negotiation from simple string comparison to RFC 4647 based
[Locale] Add some more tests for header languange negotiation
[Unit] Fix JsonApiTestCase constructor arguments
[Behat][API] Allow setting no accept-language in header
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 or 1.13 <!-- see the comment below --> |
| Bug fix? | no/yes |
| New feature? | no/yes |
| BC breaks? | no/yes |
| Deprecations? | no/yes <!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | fixes #X, partially #Y, mentioned in #Z |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
Typo cart-flow.rst
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | reactivated #13796
| License | MIT
Commits
-------
Add a support for Symfony Panther in the JS-based Behats
Fix PHPSpec scenario
Add support for Panther to CookieSetter service
Run failing scenarios on Panther with using chromedriver
Bring back the "chrome_headless_second_session" mink session
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no|
| Related tickets | replaces #15436 |
| License | MIT |
<img width="248" alt="image" src="https://github.com/Sylius/Sylius/assets/6140884/2b58b7c1-7334-4e10-9bba-de393b525f05">
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
Add business support CTA to admin panel
Add all translations & change label
[Admin] Change name of official support section in menu and adjust translations
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|-----|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#15183 |
| License | MIT |
Refs video in #15183
When we login in addressing page after submit once the page, the reload process after login resubmit data, and keep sending `form[customer][email]`, that it doesn't be added in form.
So I unset these data on pre-submit.
I also change the csrf_error message for something more "understandable".
By this way, we can still have previous submitted data for address fields.
The other way, suggested by @Wojdylak, is to change this line https://github.com/Sylius/Sylius/blob/1.12/src/Sylius/Bundle/UiBundle/Resources/private/js/sylius-api-login.js#L50
by
```
window.location = window.location.href;
```
But using it, all already filled data are lost.
WDYT ? Would it be acceptable to lose such data, or should we keep them ?
Commits
-------
[Checkout] Prevent extra fields when login in on addressing page
Update src/Sylius/Bundle/CoreBundle/Form/Type/Checkout/AddressType.php
Add tests that form doesn't display Extra fields error after login in checkout
Remove fr translation
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | n/a
| License | MIT
In some patch version, Symfony updated the return type for one of the methods to `mixed`. PHPSpec doesn't support this return type, so I had to return `anything` manually.
Commits
-------
Add missing willReturn method calls to PHPSpecs
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | kinda |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#15606 |
| License | MIT |
Commits
-------
[Admin][UI] Fix csrf error breaking admin form
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | n/a
| License | MIT |
Commits
-------
03611a4c70 Exclude PHP 8.0/Symfony 6.4 from workflows' matrixes
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | n/a
| License | MIT
I only added the package to fix full build. I skipped adding isolating to the `1.12`'s workflows.
Commits
-------
Add the sylius-labs/suite-tags-extension package
Fix product name's casing in the Behat scenario
[Maintenance] Fix postgres behats
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
[CI] Update Symfony versions in build
[Dependencies] Change possible versions of doctrine/persistence
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#15541 |
| License | MIT |
Commits
-------
[Fix] Do not show cart id after saving
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | n/a
| License | MIT
**Justification**
>Hello everyone, last Friday, we once again raised the topic of maintaining two static analysis tools within Sylius. We're wondering about switching to only one (preferably phpstan, with a change to write custom PHPStan rules for Sylius).
>
>Why? From time to time we have to face with issues when one tool is fine with some code, but another starts complaining. We're aware it (probably) increases the code quality, but at the same time, some of us find the ROI at a low level compared to (stupid) work we sometimes have to do.
Core Team Voting result:
6 votes for keeping only PHPStan
1 vote for keeping only Psalm
1 vote for keeping both
2 votes for keeping any but only one
I was wondering whether we should target it against `1.12` or `1.13`, but as it's not a hard dependency, and we still maintain `1.12`, I decided to pick this one.
Commits
-------
Remove Psalm
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | N/A |
| License | MIT |
The actual link is not well rendered on documentation website :
Commits
-------
[DOC] Fix display link in authorize page
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | copied from #14952 |
| License | MIT |
Ported from 1.13 to fix the issue of profiler warmup in CLI context breaking our installation command.
Commits
-------
fbcfda7ea2 [DX] Improve ChannelCollector customizability
