This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
Commits
-------
Add a conflict for doctrine/orm:2.15.2
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | partially #14019 |
| License | MIT |
Commits
-------
[PHPStan] Bump to level 5 (#14019)
[PHPStan] Fix PHPStan level 5 class inheritance errors (#14019)
[PHPStan] Fix PHPStan to continue support for Sf < 6 (#14019)
[PHPStan] Fix non nullable variable (#14019)
[PHPStan] Fix Psalm (#14019)
[Fixture] Revert injected repository type
Fix typo
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes (documentation) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no
| Related tickets | |
| License | MIT |
ChannelContext priority is 0, not -128, see 8b130ffa26/src/Sylius/Bundle/ChannelBundle/Resources/config/services.xml (L43-L47)
Commits
-------
2e766c97cd Change prority for custom ChannelContext
This PR was merged into the 1.12 branch.
Discussion
----------
This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yaml).
Commits
-------
[CS][DX] Refactor
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 and 1.13 <!-- see the comment below --> |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
[Psalm] Add CacheableSupportsMethodInterface to the deprecated classes list
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets | fixes#14868
| License | MIT
Once the `RequestHeaderBasedLocalContext` service introduced, it took a priority over the `RequestBasedLocaleContext` service.
AFAIR the main purpose of the `RequestHeaderBasedLocalContext` service was aimed to allow a language switching for the API, but it affected the UI part too. I decided to lower the priority, so URL is considered as a first.
Any tests will be delivered once I decide how to test it 🥶.
Commits
-------
ce30820c2d Lower the sylius.context.locale tag priority on RequestHeaderBasedLocalContext
88bb5f1548 Cover locale resolving with functional tests
1ef726d1ff Remove redundant fixtures from LocaleResolving functional test
7ff4567187 Add purging a database before CartCollector no channel test
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | https://github.com/Sylius/Sylius/pull/14950
| License | MIT |
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
0b412d75b2 [PostgreSQL][Installer] Handle Sylius installation with PostgreSQL
3778d14835 [Installer] Don't pass a suite parameter if not provided
2c18f307cc [ECS] Apply ecs fixes
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no? |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes#14131 |
| License | MIT |
Inb4 someone asks why there's no API coverage or `no-api` tags:
- sorting is possible via API so `no-api` does not apply
- coupons have no crud in API ATM
- catalog promotions have no sorting specified in API
The 2 last points would be doable in this PR, but then it would have to go to 1.13 since new features would be introduced, and I see no point in blocking the bugfix part alone for 1.12.
Commits
-------
9cefb206b0 [Admin] Fix inability of sorting promotion coupons and catalog promotions
6d170e5127 [UI][Behat] Sorting promotion coupons
8564ed5431 [UI][Behat] Sorting catalog promotions
e88b0f4eaa [Behat][Postgres][Promotion] Disable sorting scenarios for nullable fields
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | Replacement of #12150 , #12308, fixes#11879#11712 |
| License | MIT |
Bug present since 2018, report in 2020/2021/2022
Still no correction, hope this PR will work...
Don't ask to do a regression test, done in April 2021, search when the function is created in the js file, it's been done on 15 Jun 2018 and no update since ( 72bda8f3cb )
the event.originalEvent.pageX != 0 seems to be another solution, as I detailled here : https://github.com/Sylius/Sylius/issues/11712
ClientX/ClientY PageX/PageY ScreenX/ScreenY are at 0 for the Enter pressed but with number when Button clicked
and if I check https://caniuse.com/?search=pageX it's seems to be used on many browser
@vvasiloi @lchrusciel @Zales0123
**Please** validate this PR to correct for once this bug present since 5 years (and nobody want to correct it ??!!)
Sorry to tag you all, but can you verify this PR
@AdamKasp @Arminek @CoderMaggie @czechmarcin @GSadee @jacquesbh @kulczy @mamazu @pamil @pjedrzejewski @Tomanhez
Commits
-------
Fix the press enter cause attribute deletion
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
This ECS refactor shouldn't be merged, as there's a bug with semicolons fixer.
Commits
-------
ddfc614e59 Revert "[CS][DX] Refactor"
This PR was merged into the 1.12 branch.
Discussion
----------
This PR has been generated automatically.
For more details see [refactor.yaml](/Sylius/Sylius/blob/1.12/.github/workflows/refactor.yaml).
Commits
-------
[CS][DX] Refactor
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Related tickets |
| License | MIT
In `php-http/message:1.16.0` the package `php-http/message-factory` has been removed from the list of dependencies. We use it to check backward compatibility, so I added it as a dev deps to AdminBundle, what will fix our CI.
Commits
-------
Add php-http/message-factory as a dev dependency to fix tests
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> |
| License | MIT |
Commits
-------
[Fix][Migrations] Extend migration with a proper AbstractMigration class
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | yes (although only in behat) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
Commits
-------
[Behat][Api] Make sure taxon iri is in right section
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | follow up to https://github.com/Sylius/Sylius/pull/14940 |
| License | MIT |
Commits
-------
[Behat] Minor fixes in ShippingContext
[Behat] Minor fix in a scenario
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 or 1.13 <!-- see the comment below --> |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
I propose this modification, in order that the default shipping method is selected according to the position of the methods in the admin, even when the customer does not have an address yet.
<!--
- Bug fixes must be submitted against the 1.12 branch
- Features and deprecations must be submitted against the 1.13 branch
- Make sure that the correct base branch is set
To be sure you are not breaking any Backward Compatibilities, check the documentation:
https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
Commits
-------
default shipping methods order by position
Merge branch 'Sylius:1.12' into 1.12
Merge branch 'Sylius:1.12' into 1.12
Behat scenario
Add @api tag
Update features/cart/shopping_cart/resolving_default_shipping_method_in_cart_summary_based_on_method_position.feature
This PR was merged into the 1.12 branch.
Discussion
----------
| Q | A |
|-----------------|--------------------------------------------------------------|
| Branch? | 1.12 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | partially #14019 |
| License | MIT |
Commits
-------
4bc2aa7c01 [PHPStan] Bump to level 4 (#14019)
ac1b7f69f2 [PHPStan] Ignore properties not used to avoid BC (#14019)
b26c4ba3d1 [PHPStan] Fix static errors (#14019)
d1f4aa6fa1 [PHPStan] Maybe we can not trust the Symfony docblock in method (#14019)
We chose to maintain this condition to avoid potential errors
720fb4e1ba [PHPStan] Maybe the priority is not given in the configuration parameter (#14019)
We chose to maintain this condition to avoid potential errors
e97d93bb0b Improve solutions fixing errors reported by PHPStan level 4
